Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate to yargs #94

Merged
merged 3 commits into from
Oct 17, 2024
Merged

feat: migrate to yargs #94

merged 3 commits into from
Oct 17, 2024

Conversation

de-don
Copy link
Contributor

@de-don de-don commented Sep 12, 2024

closes #86

@de-don
Copy link
Contributor Author

de-don commented Sep 12, 2024

@JoshuaKGoldberg looks like CI is not configured properly :(

@Cellule
Copy link

Cellule commented Oct 10, 2024

@JoshuaKGoldberg Any chance we can get this merged in?

@Cellule
Copy link

Cellule commented Oct 10, 2024

@JoshuaKGoldberg looks like CI is not configured properly :(

Because the pipeline are defined in #89
Normally you shouldn't put a pipeline required in the settings until it has been merged in

@JoshuaKGoldberg
Copy link
Owner

Ha, yeah, I'd run create-typescript-app and meant to merge, then got pulled away for other things. I should be able to get to #89 and this Soon™️. Sorry for the delay!

JoshuaKGoldberg
JoshuaKGoldberg requested changes Oct 15, 2024
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry again for the wait here. I don't think it's working? Am I missing something?

bin/pjv Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Oct 15, 2024
@github-actions github-actions bot removed the status: waiting for author Needs an action taken by the original poster label Oct 16, 2024
@de-don
Copy link
Contributor Author

de-don commented Oct 16, 2024

@JoshuaKGoldberg sorry, I forgot to mark these options as boolean. Should be fixed

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 17, 2024
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 this is lovely, thanks @de-don!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 58656fc into JoshuaKGoldberg:main Oct 17, 2024
5 checks passed
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @de-don for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors bot mentioned this pull request Oct 17, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @de-don! 🎉

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited by JoshuaKGoldberg
Loading

🎉 This is included in version v0.7.0 🎉

The release is available on:

Cheers! 📦🚀

@Cellule Cellule mentioned this pull request Oct 17, 2024
Merged
3 tasks
@Cellule
Copy link

Cellule commented Oct 17, 2024

Awesome thanks!
I opened a PR to update to 0.7.0 in JoshuaKGoldberg/eslint-plugin-package-json#569

JoshuaKGoldberg pushed a commit that referenced this pull request Oct 18, 2024
@allcontributors
docs: add de-don as a contributor for code (#99)
d3818d7 
Adds @de-don as a contributor for code.

This was requested by JoshuaKGoldberg [in this
comment](#94 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
JoshuaKGoldberg pushed a commit to JoshuaKGoldberg/eslint-plugin-package-json that referenced this pull request Oct 18, 2024
@Cellule
fix: update dependency package-json-validator to v0.7.0 (#569)
9d44862 
<!-- 👋 Hi, thanks for sending a PR to eslint-plugin-package-json! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

Get fixes to remove minimist from the resulting package
JoshuaKGoldberg/package-json-validator#94

## PR Checklist

-   [ ] Addresses an existing open issue: fixes #000
- [ ] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [ ] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

<!-- Description of what is changed and how the code change does that.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Switch from optimist (deprecated) to yargs
3 participants
@de-don @Cellule @JoshuaKGoldberg