-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add --help
, introduce "any" reason, explain filter when no notifications found
#196
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
coverage*/ | ||
lib/ | ||
node_modules/ | ||
.aider* | ||
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -114,4 +114,27 @@ describe("pruneGitHubNotifications", () => { | |||||||
] | ||||||||
`); | ||||||||
}); | ||||||||
|
||||||||
it("logs a message when no notifications match the filters", async () => { | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Testing] If we're going with the feature as-is, I'd request a test for the inverse - that when
Suggested change
...but, TBD, maybe we'll go with something fancier? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yea we should probably just do a verbose flag or something! I don't know how you feel about the debug module, but I'm also a big fan of that |
||||||||
vi.spyOn(console, "log").mockImplementation(() => { | ||||||||
// Noop | ||||||||
}); | ||||||||
|
||||||||
mockRequest.mockResolvedValueOnce({ | ||||||||
data: [ | ||||||||
{ | ||||||||
id: "90", | ||||||||
reason: "different", | ||||||||
subject: { | ||||||||
title: "unmatched title", | ||||||||
}, | ||||||||
}, | ||||||||
], | ||||||||
}); | ||||||||
|
||||||||
const result = await pruneGitHubNotifications({ logFilterWhenEmpty: true }); | ||||||||
|
||||||||
expect(result.threads).toEqual([]); | ||||||||
expect(console.log).toHaveBeenCalled(); | ||||||||
}); | ||||||||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Tooling]
Which reminds me, thanks - JoshuaKGoldberg/dot-com#337