Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Increase supported TS versions to reflect the passage of time (April/May 2023) #206

Closed
3 tasks done
JoshuaKGoldberg opened this issue Apr 27, 2023 · 0 comments · Fixed by #207
Closed
3 tasks done

🚀 Feature: Increase supported TS versions to reflect the passage of time (April/May 2023) #206

JoshuaKGoldberg opened this issue Apr 27, 2023 · 0 comments · Fixed by #207
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Apr 27, 2023 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

TypeScript 4.2 is over 2 years old now. And there is some internal code that has to check whether the TS version is >=4.3 or not:

ts-api-utils/src/tokens.ts

Line 38 in 6050cfe

const isTS4dot3 = isTsVersionAtLeast(4, 3);

Let's drop support for TS 4.2 and update .github/test.yml.

Additional Info

Technically, because this library is still 0.X, dropping support for TypeScript 4.2 wouldn't constitute a violation of semver. This would be a good opportunity to bump to a next minor version. Related: #170
@JoshuaKGoldberg JoshuaKGoldberg added the type: feature New enhancement or request 🚀 label Apr 27, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Apr 27, 2023
@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send a pull request to resolve this! 🙏 label Apr 27, 2023
This was referenced Apr 27, 2023
Merged
Merged
JoshuaKGoldberg added a commit that referenced this issue Jun 15, 2023
@JoshuaKGoldberg @RebeccaStevens
chore: bumped minimum TypeScript version to 4.3 (#207)
279f843 
## PR Checklist

- [x] Addresses an existing open issue: fixes #206
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/ts-api-utils/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/ts-api-utils/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Raises the lowest tested version to 4.3 and removes code that supports
earlier versions (i.e. 4.2). Bumps the version to ~0.1.0~ 0.2.0
accordingly.

---------

Co-authored-by: Rebecca Stevens <rebecca.stevens@outlook.co.nz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: bumped minimum TypeScript version to 4.3 JoshuaKGoldberg/ts-api-utils
1 participant
@JoshuaKGoldberg