Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Dev #2

Merged
merged 11 commits into from
Nov 6, 2021
Merged

Dev #2

merged 11 commits into from
Nov 6, 2021

Conversation

JosiahBull
Copy link
Owner

@JosiahBull JosiahBull commented Nov 6, 2021 •
edited
Loading

Fix #13

JosiahBull and others added 9 commits November 3, 2021 22:10
@JosiahBull
feat (configuration): Implemented broader configuration options for t…
ff04055 
…he api, with proper loading from environment with fallback to ./config/general.toml.
@github-actions
Format Rust code using rustfmt
a73b165
@JosiahBull
feat (cache): Basic cache features implemented. Not integrated with m…
b233490 
…ain program yet.

- Basic test written
- Save & Load items
- Some useful fields for data etc
@JosiahBull
tests (cache): Wrote more tests for the caching interface.
d93f0fc 
- testing size/item limits
- testing duplicate keys
- testing underlying hashmap
@JosiahBull
Update test.yml
69c02f3
@JosiahBull
feat (cache): Cache popularity swapping properly implemented.
5dd7dac
@JosiahBull
fix (ci/cd): Fixed a bug in the ci/cd. Festival is now properly insta…
0326666 
…lled for testing.
@JosiahBull
fix (conversion): Fixed a bug in the conversion endpoint which broke …
790f3d0 
…account rate limiting.
@github-actions
Format Rust code using rustfmt
ddbd208
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2021 •
edited
Loading

Codecov Report

Merging #2 (9b3de63) into main (35bee40) will increase coverage by 13.51%.
The diff coverage is 85.35%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main       #2       +/-   ##
===========================================
+ Coverage   70.60%   84.11%   +13.51%     
===========================================
  Files           4        6        +2     
  Lines         347      340        -7     
===========================================
+ Hits          245      286       +41     
+ Misses        102       54       -48
Impacted Files Coverage Δ
src/response.rs 78.26% <0.00%> (+19.16%) ⬆️
src/common.rs 79.62% <72.72%> (+6.55%) ⬆️
src/cache.rs 83.33% <83.33%> (ø)
src/macros.rs 85.71% <85.71%> (ø)
src/main.rs 92.53% <86.66%> (+16.59%) ⬆️
src/models.rs 70.00% <100.00%> (+30.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8035efe...9b3de63. Read the comment docs.

@JosiahBull JosiahBull self-assigned this Nov 6, 2021
@JosiahBull JosiahBull added the enhancement New feature or request label Nov 6, 2021
@JosiahBull JosiahBull linked an issue Nov 6, 2021 that may be closed by this pull request
Add configuration in /config/general.toml #13
Closed
5 tasks
@JosiahBull
chore (clippy/fmt): Ran clippy and rustfmt and satisified all lints.
b5b4a6f 
Also added in some templates and improved the ci/ci pipeline in some minor ways.
@JosiahBull JosiahBull marked this pull request as ready for review November 6, 2021 08:50
@JosiahBull JosiahBull merged commit 1f05b1a into main Nov 6, 2021
@JosiahBull JosiahBull deleted the dev branch November 6, 2021 09:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@JosiahBull JosiahBull

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add configuration in /config/general.toml
2 participants
@JosiahBull @codecov-commenter