This repository has been archived by the owner on May 14, 2024. It is now read-only.
Refactor #23
Merged
Refactor #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her than a bunch of lazy_statics. Advantages - Easier to test with - More configurable - Drop the lazy_static dependency Disadvantages: - Cumbersome, have to pass in the config to every function now. - Potentially slower, as the code has to process an extra step in the request guard. All in all, I believe this is a worthwhile tradeoff.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored some code out into submodules, helping to reduce bloat. Especially the testing code.
Configuration received a major rework, and as part of that I bundled fixing #8.
Closes #8
Closes #22
Checklist: