refactor: comply with Step-down Rule

Josuto · Apr 28, 2024 · de32079 · de32079
1 parent 4d20b18
commit de32079
Showing 1 changed file with 34 additions and 17 deletions.
diff --git a/src/mongoose.repository.ts b/src/mongoose.repository.ts
@@ -191,38 +191,48 @@ export abstract class MongooseRepository<T extends Entity & UpdateQuery<T>>
       throw new IllegalArgumentException(
         'The given entity cannot be null or undefined',
       );
-    const entityClassName = entity['constructor']['name'];
-    if (!this.typeMap.has(entityClassName)) {
-      throw new IllegalArgumentException(
-        `The entity with name ${entityClassName} is not included in the setup of the custom repository`,
-      );
-    }
-    this.setDiscriminatorKeyOn(entity);
-    const document = this.createDocumentAndSetUserId(entity, options?.userId);
+    const document = this.createDocumentForInsertion(entity, options);
     const insertedDocument = (await document.save({
       session: options?.session,
     })) as HydratedDocument<S>;
     return this.instantiateFrom(insertedDocument) as S;
   }
 
-  private setDiscriminatorKeyOn<S extends T>(
+  private createDocumentForInsertion<S extends T>(
+    entity: S,
+    options?: SaveOptions,
+  ) {
+    this.setDiscriminatorKeyOnEntity(entity);
+    const document = new this.entityModel(entity);
+    this.setAuditableDataOnDocumentToInsert(document, entity, options?.userId);
+    return document;
+  }
+
+  private setDiscriminatorKeyOnEntity<S extends T>(
     entity: S | PartialEntityWithId<S>,
   ): void {
     const entityClassName = entity['constructor']['name'];
+    if (!this.typeMap.has(entityClassName)) {
+      throw new IllegalArgumentException(
+        `The entity with name ${entityClassName} is not included in the setup of the custom repository`,
+      );
+    }
     const isSubtype = entityClassName !== this.typeMap.getSupertypeName();
     const hasEntityDiscriminatorKey = '__t' in entity;
     if (isSubtype && !hasEntityDiscriminatorKey) {
       entity['__t'] = entityClassName;
     }
   }
 
-  private createDocumentAndSetUserId<S extends T>(entity: S, userId?: string) {
-    const document = new this.entityModel(entity);
+  private setAuditableDataOnDocumentToInsert<S extends T>(
+    document: HydratedDocument<S>,
+    entity: S,
+    userId?: string,
+  ): void {
     if (isAuditable(entity)) {
       if (userId) document.$locals.userId = userId;
       document.__v = 0;
     }
-    return document;
   }
 
   /**
@@ -247,11 +257,7 @@ export abstract class MongooseRepository<T extends Entity & UpdateQuery<T>>
       .session(options?.session ?? null);
     if (document) {
       document.set(entity);
-      document.isNew = false;
-      if (isAuditable(document)) {
-        if (options?.userId) document.$locals.userId = options?.userId;
-        document.__v = (document.__v ?? 0) + 1;
-      }
+      this.setAuditableDataOnDocumentToUpdate(document, options?.userId);
       const updatedDocument = (await document.save({
         session: options?.session,
       })) as HydratedDocument<S>;
@@ -262,6 +268,17 @@ export abstract class MongooseRepository<T extends Entity & UpdateQuery<T>>
     );
   }
 
+  private setAuditableDataOnDocumentToUpdate<S extends T>(
+    document: HydratedDocument<S>,
+    userId?: string,
+  ): void {
+    document.isNew = false;
+    if (isAuditable(document)) {
+      if (userId) document.$locals.userId = userId;
+      document.__v = (document.__v ?? 0) + 1;
+    }
+  }
+
   /** @inheritdoc */
   async deleteById(id: string, options?: DeleteByIdOptions): Promise<boolean> {
     if (options?.connection)