Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Customizable title #369

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lukengda
Copy link
Contributor

@lukengda lukengda commented Mar 13, 2024

Hi, i am proposing another change: We added two customization features to enable more use cases for this software. All changes are done with fallbacks to the default how it always was and how it is probably useful in most cases. We want to use the software in a context where we need to customize the following:

  • Customizing the header title
  • Disabling the version check (to not bother clients that cant admin the server).

During the testing for these changes, i found an error in an error page that i fixed in a separate commit.

I hope i implemented these changes respecting your original intent for the software. Let me know what you think!

Lukas Engelter added 4 commits March 13, 2024 18:47
this way it is possible to go back to the main view, even if two layers deep, i.e. in the history view.
we already have REGISTRY_TITLE, but it is used as a reference to where the images come from: "Repositories of …". The UI however does not need to be used in a 1:1 context of the registry. Therefore, the project would benefit from this feature:

We therefore introduce "UI_TITLE" as a new option, that optionally allows to change the title for more advanced customization and to enable more use cases for this software.

If it is not set, everything will stay the same as prior to this commit and the title will remain "Docker Registry UI"

Note, that the footer will always contain a reference to this project. I think it doesn't need to referenced twice, and makes room for some more customization.
Note: The default remains to have the version check enabled. It is though sometimes useful to disable it, in the context of customers or open source interests of your software not to bother with version updates to Docker Registry UI.

For example, if you use something like watchtower anyway, there is no need to bother with update notifications to anyone else other then the admin of the server.
The environment variables named in the CATALOG_BRANCHING_CONFIGURATION error were wrong.

During that find, i found out that one needs to set both min and max to 0 to disable branching. I tried to make this clear in the README.md file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant