-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Feature: Overview of tag history content #58
Conversation
Hey! Thank you for your contribution ! 👍 This is a good job, well done 😉 For the v2 API, you can use the object {
"architecture": "amd64",
"config": {
"Hostname": "",
"Domainname": "",
"User": "",
"AttachStdin": false,
"AttachStdout": false,
"AttachStderr": false,
"Tty": false,
"OpenStdin": false,
"StdinOnce": false,
"Env": [
"PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
],
"Cmd": [
"/bin/sh"
],
"ArgsEscaped": true,
"Image": "sha256:adc791c55308c575fb7c2103801fa03d46ad1c9b9e7942afd47fcf5968d78bc0",
"Volumes": null,
"WorkingDir": "",
"Entrypoint": null,
"OnBuild": null,
"Labels": null
},
"container": "046231b489fcba3dc42e6424d476762ecc5140a075fefc2c03eace14f143ad58",
"container_config": {
"Hostname": "046231b489fc",
"Domainname": "",
"User": "",
"AttachStdin": false,
"AttachStdout": false,
"AttachStderr": false,
"Tty": false,
"OpenStdin": false,
"StdinOnce": false,
"Env": [
"PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
],
"Cmd": [
"/bin/sh",
"-c",
"#(nop) ",
"CMD [\"/bin/sh\"]"
],
"ArgsEscaped": true,
"Image": "sha256:adc791c55308c575fb7c2103801fa03d46ad1c9b9e7942afd47fcf5968d78bc0",
"Volumes": null,
"WorkingDir": "",
"Entrypoint": null,
"OnBuild": null,
"Labels": {}
},
"created": "2018-01-09T21:11:19.25867595Z",
"docker_version": "17.06.2-ce",
"history": [
{
"created": "2018-01-09T21:11:19.026384377Z",
"created_by": "/bin/sh -c #(nop) ADD file:85ed2ac9d10c6f076a01f29e72b653675994c6fcfb90f0e6b88368c0262893fa in / "
},
{
"created": "2018-01-09T21:11:19.25867595Z",
"created_by": "/bin/sh -c #(nop) CMD [\"/bin/sh\"]",
"empty_layer": true
}
],
"os": "linux",
"rootfs": {
"type": "layers",
"diff_ids": [
"sha256:c9e8b5c053a2dda62373bc57fa8cb634230a92ba5f02d2baf5d35b932d04a878"
]
}
} If you want to retrieve an image blob, you need to use your manifest endpoint with this header Hahaha, yes, your indentation is well configured 😉 All the best from France PS: Don't worry, I'm also a backend engineer/DevOPS and not a frontend expert 😉 |
Hey there! I edited all your change-requests... ✅ The mentioned possible features about fsLayers section and signatures information I would like to put in another pull-requests. Maybe wait for some feedback if it's really worth the effort! :) |
I don't know if fsLayers are interesting here, need to think about it. |
The href="#" was troubling the view that the history appeared just for a few milliseconds... the button with given onclick event does work now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last changes I think 😄
Thank you for your code-change requests... good stuff! I think I can manage to implement them untill the upcoming weekend! 👍 |
Hi Joxit! The GUI looks pretty good with your idea of using the following structure:
And your code improvement suggestion made me do a nice Looks way better with this I think!
What do you think?! 😎 |
Yeah! That's really nice job! I like this new GUI for history 😄 |
Sweet! Nice to hear that! 😍 |
I am happy to have helped you in your frontend skills 😄. I've changed the docker image in a6b6c15, the old one was too detailed. |
Considering the docker registry provides information about the tag history with the following REST endpoint (
http://localhost:5000/v2/{imageName}/manifests/{tag}
) this feature should display given information.The following modification to the
taglist
view were made to access a new page, which list the given registry JSON data.Modification on the taglist view
New overview of v2/{imageName}/manifest/{tag} contents
Possible future todos:
So... what do you think? 😀 I personally believe that information provided by the v2 REST API are worth to be displayed. Thus, it might be a good idea to think about!
I look forward to your constructive feedback and hope my indentation was properly configured!
All the best from Germany,
Lennart Blom
P.S: Don't be too strict with my JavaScript. I am a passionate Java backend engineer and unfortunately can't look back on much experience in the frontend area at the moment.