Fix hydra-typegen to properly generate types for deprecated/deleted events & extrinsics
#531
Conversation
…port for deprecated events/call affects: @joystream/hydra-typegen
There was a problem hiding this comment.
Works as planned.
Its also possible for a module to be removed from latest runtime in which case extractCall and extractEvent will throw "No metadata found for module xyz".
Does it make sense to add support for missing modules now so we don't have to make it in future?
Good point. Addressed that in 3143361 |
zeeshanakram3
force-pushed
the
fix-typegen-for-deprecated-events
branch
from
3143361
to
84243e8
Compare
| @@ -136,34 +136,74 @@ types don't much the metadata definiton`, | |||
| strict: flags.strict, | |||
| } as IConfig | |||
| } | |||
|
|
|||
| async buildGeneratorConfigs(config: IConfig): Promise<GeneratorConfig[]> { | |||
| async buildGeneratorConfigs(config: IConfig): Promise<{ | |||
There was a problem hiding this comment.
Just need an extra line here to satisfy linter ;)
https://github.com/Joystream/hydra/pull/531/checks#step:4:365
| async buildGeneratorConfigs(config: IConfig): Promise<{ | |
| async buildGeneratorConfigs(config: IConfig): Promise<{ |
There was a problem hiding this comment.
you can do it manually with yarn lint --fix
addresses Joystream/joystream#4877
based on #527