stick with rust v1.46.0 for successful build #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems latest version of rust v1.47.0 is causing a problem when combined with nightly-2020-05-23.
Additionally latest version of clippy also causes some warnings (which we treat as errors) in substrate pallet crates.
So the recommended fix for in #495 only really works for building node and runtime but breaks clippy.
So I think the safest fix for now is to stick with rust v1.46.0 and nightly-2020-05-23 for WASM build.
I updated the
setup.shto install v1.46.0 rather than the latest which gets installed by the "getsubstrate.io" bootstrap script.