Distribution feature for the storage pallet. #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # runtime-modules/storage/src/lib.rs # runtime-modules/storage/src/tests/mod.rs
# Conflicts: # runtime-modules/storage/src/lib.rs # runtime/src/lib.rs
- delete_distribution_bucket_family # Conflicts: # runtime-modules/storage/src/lib.rs
- add ‘create_distribution_bucket’ extrinsic - add MaxDistributionBucketNumberPerFamily constant # Conflicts: # runtime-modules/storage/src/tests/fixtures.rs
- add `update_distribution_bucket_status` extrinsic # Conflicts: # runtime-modules/storage/src/lib.rs
- add `delete_distribution_bucket` extrinsic
- add `update_distribution_buckets_for_bag` - add `DistributionBucketsPerBagValueConstraint` constant # Conflicts: # runtime-modules/storage/src/bag_manager.rs # runtime-modules/storage/src/tests/mod.rs
Fix `update_storage_buckets_for_bag` extrinsic. Change bucket limit comparison. # Conflicts: # runtime-modules/storage/src/lib.rs # runtime-modules/storage/src/tests/mod.rs
- add `distribution_buckets_per_bag_limit` # Conflicts: # runtime-modules/storage/src/tests/mod.rs
- add `update_distribution_bucket_mode` extrinsic # Conflicts: # runtime-modules/storage/src/lib.rs
- add `update_families_in_dynamic_bag_creation_policy ` extrinsic
# Conflicts: # runtime-modules/storage/src/lib.rs # runtime-modules/storage/src/tests/mod.rs
- add `invite_distribution_bucket_operator` # Conflicts: # runtime-modules/storage/src/lib.rs
- add `cancel_distribution_bucket_operator_invite`
- add `accept_distribution_bucket_invitation`
- add `set_distribution_operator_metadata`
- add `MaxNumberOfPendingInvitationsPerDistributionBucket`
- add `remove_distribution_bucket_operator`
- add ‘assigned_bags’ number - change ‘delete_distribution_bucket’ and ‘delete_distribution_bucket’ extrinsics (add bag assignment checks)
- rename and remove mutable variables.
bedeho
approved these changes
Jul 30, 2021
runtime-modules/storage/src/lib.rs
Outdated
| /// Distribution bucket family. | ||
| #[cfg_attr(feature = "std", derive(Serialize, Deserialize))] | ||
| #[derive(Encode, Decode, Default, Clone, PartialEq, Eq, Debug)] | ||
| pub struct DistributionBucketFamilyObject<DistributionBucketId: Ord, WorkerId: Ord> { |
There was a problem hiding this comment.
Why are you introducing the Object post-fix for the bucket family and bucket? The reason DataObject has the this is because it explicitly is supposed to be represent the idea of an object or blob, this does not apply to these other types.
There was a problem hiding this comment.
Fixed here: dca15ca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes this draft PR.
Initial specification.
Changes
New extrinsics
Constants
New types
New storage entries