Update from node v14 to v18.6.0 #4778
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
package.json
Outdated
| @@ -66,11 +66,11 @@ | |||
| } | |||
| }, | |||
| "engines": { | |||
| "node": ">=14.0.0", | |||
| "node": ">=14.6.1", | |||
There was a problem hiding this comment.
If Volta is not installed, then this engine requirement could break things. I got the following error while installing dependencies using node 14.7.0.
[1/6] Validating package.json...
[2/6] Resolving packages...
[3/6] Fetching packages...
error file-type@17.1.1: The engine "node" is incompatible with this module. Expected version "^12.20.0 || ^14.13.1 || >=16.0.0". Got "14.7.0"
error Found incompatible module.
So the engine min version needs to be increased. Things seem to work at the minimum of 14.18.0 (version previously defined in "volta" section)
README.md
Outdated
| @@ -12,7 +12,7 @@ functionality to support the [various roles](https://joystream.gitbook.io/testne | |||
| The following tools are required for building, testing and contributing to this repo: | |||
|
|
|||
| - [Rust](https://www.rust-lang.org/tools/install) toolchain - _required_ | |||
| - [nodejs](https://nodejs.org/) v14.x - _required_ | |||
| - [nodejs](https://nodejs.org/) >= v18.6 - _required_ | |||
There was a problem hiding this comment.
shouldn't be v14.x.x i.e. the minimum node version defined in the engine section?
There was a problem hiding this comment.
Will fix, I think I changed that originally when I was forcing all engine filed to be >=18
|
@zeeshanakram3 Applied your feedback, I also update Readme to document the fact that old version of linux will not support node v18, so I include a workaround. |
|
Looks good, I think we should use the same nodes engine requirement ( |
done in 4a985be |
Co-authored-by: Zeeshan Akram <37098720+zeeshanakram3@users.noreply.github.com>
Co-authored-by: Zeeshan Akram <37098720+zeeshanakram3@users.noreply.github.com>
Updated all volta sections in repo package.json files to use node 18, as well is in github workflows and docker images.
I did not change the min version in engine sections to prevent breaking any deployments where volta is not used or forcing users to upgrade. But as long as volta is used, it will trigger it to update and use new version.