-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crt release v1 #4871
Crt release v1 #4871
Conversation
This reverts commit 862993afdb9838c52066cdfe099444c863f8bbfc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few more comments.
The most important issue however is the need to initialize the amm_treasury_account
with existential deposit which we do for all module accounts, with an on_runtime_update migration.
92f4c52
to
8594cd0
Compare
ba33902
to
3066093
Compare
be9a239
to
bf4b872
Compare
This reverts commit bf4b872.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
just some minor points.
This PR contains all the fixes for v1 in order for allow Orion (and Atlas) to progress
Changes (and issues addressed)
issue_token
#4789ExistentialDeposit
Initialise CRT module account on runtime upgrade #4198TransferOutput
parameter a bounded vector and add a minimum allowed value for the Amma
┆Issue is synchronized with this Asana task by Unito