Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crt release v1 #4871

Merged
merged 214 commits into from
Nov 2, 2023
Merged

Crt release v1 #4871

merged 214 commits into from
Nov 2, 2023

Conversation

ignazio-bovo
Copy link
Contributor

@ignazio-bovo ignazio-bovo commented Sep 14, 2023

This PR contains all the fixes for v1 in order for allow Orion (and Atlas) to progress

Changes (and issues addressed)

┆Issue is synchronized with this Asana task by Unito

Copy link
Member

@mnaamani mnaamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few more comments.
The most important issue however is the need to initialize the amm_treasury_account with existential deposit which we do for all module accounts, with an on_runtime_update migration.

runtime-modules/content/src/lib.rs Outdated Show resolved Hide resolved
query-node/mappings/src/content/channel.ts Outdated Show resolved Hide resolved
query-node/mappings/src/content/channel.ts Outdated Show resolved Hide resolved
query-node/mappings/src/proposals.ts Show resolved Hide resolved
runtime-modules/project-token/src/lib.rs Show resolved Hide resolved
runtime-modules/project-token/src/lib.rs Outdated Show resolved Hide resolved
@ignazio-bovo ignazio-bovo requested a review from mnaamani October 19, 2023 07:23
yarn.lock Outdated Show resolved Hide resolved
Copy link
Member

@mnaamani mnaamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
just some minor points.

runtime/src/lib.rs Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
runtime-modules/project-token/Cargo.toml Outdated Show resolved Hide resolved
@ignazio-bovo ignazio-bovo requested a review from mnaamani October 25, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants