bash scripts: proper error handling when invoking sub shell scripts #4917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #4913 and #4935
General fix to all shell scripts to correctly exit script when calling a sub script fails.
TLDR:
we have
set -ein scripts that needs to exit when a subscript fails.Using this:
output=$( expression )captures output but doesn't cause calling script to exit with error. (You have to manually check exit code with
$?)output=`expression`Works better because it captures output and a non zero exit code from the expression/script with make the calling script exit correctly with an error code.
┆Issue is synchronized with this Asana task by Unito