Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to polkadot v0.9.41 #4932

Merged
merged 14 commits into from
Nov 7, 2023

Conversation

mnaamani
Copy link
Member

@mnaamani mnaamani commented Oct 15, 2023

Fixes #4918

  • update to use joystream substrate fork of polkadot-v0.9.41 branch + related fixes
  • Re-enable renaming pallet BagsList to VoterList to be inline with polkadot (to ensure polkadot-js apps staking app compatibility) after modifying the migration in substrate to skip "problematic" post upgrade check.
  • bump wasmtime crate to v6.0.2
  • bump trie-db to v0.27.1

┆Issue is synchronized with this Asana task by Unito

@mnaamani mnaamani requested a review from ignazio-bovo October 16, 2023 06:19
@mnaamani mnaamani marked this pull request as ready for review October 16, 2023 06:19
@bedeho bedeho mentioned this pull request Oct 16, 2023
@mnaamani
Copy link
Member Author

ref: #4736 (comment)

Copy link
Contributor

@ignazio-bovo ignazio-bovo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have no major remarks
The question on the stackexchange is still unanswered.
If the failing check is suggesting that the keys starting with old_prefix are not exactly removed from storage, does it imply that move_pallet actually performs a copy?

@mnaamani
Copy link
Member Author

mnaamani commented Nov 6, 2023

If the failing check is suggesting that the keys starting with old_prefix are not exactly removed from storage, does it imply that move_pallet actually performs a copy?

No, I'm pretty sure it does move based on looking at the implementation and testing the chain to confirm nothing was at the prefix anymore.

@mnaamani mnaamani merged commit 2eb1715 into Joystream:nara Nov 7, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants