[Argus] fix: Parse Axios error before logging & exporting to the Elasticsearch #4944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnaamani
reviewed
Oct 24, 2023
| @@ -332,7 +332,9 @@ export class NetworkingService { | |||
| }) | |||
|
|
|||
| objectDownloadQueue.on('error', (err) => { | |||
| this.logger.error('Download attempt from storage node failed after availability was confirmed:', { err }) | |||
| this.logger.error('Download attempt from storage node failed after availability was confirmed:', { | |||
| err: parseAxiosError(err), | |||
There was a problem hiding this comment.
If err is not an instance of AxiosError will parsing fail?
Perhaps parse only if axios.isAxiosError(err) == true
There was a problem hiding this comment.
Addressed here 8ebd130
mnaamani
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Thanks to @kdembler for investigation