-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated Weights #4958
Generated Weights #4958
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks ok:
- the new extrinsics weight scale (
buy/sell_on_amm
looks plausible) - in the creator token
*-transfer
extrinsic the metadata parameter now is accounted for and possibly it dominates theoutput
size parameter
besides the metadata weight I don't have any other major remark
Weight::from_parts(100_964_050, 0u64) | ||
.saturating_add(Weight::from_parts(0, 20544)) | ||
// Standard Error: 50_287 | ||
.saturating_add(Weight::from_parts(11_041_181, 0u64).saturating_mul(o.into())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, the metadata seems to be accounted for now...
// Standard Error: 67_129 | ||
.saturating_add(Weight::from_parts(12_404_421, 0u64).saturating_mul(a.into())) | ||
// Standard Error: 15_985 | ||
.saturating_add(Weight::from_parts(1_124_562, 0u64).saturating_mul(b.into())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why beforehand the metadata weight b
wasn't even considered...
┆Issue is synchronized with this Asana task by Unito