Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Luxor/reward-curve-proposal #5086

Merged
merged 19 commits into from
Apr 4, 2024
Merged

Luxor/reward-curve-proposal #5086

merged 19 commits into from
Apr 4, 2024

Conversation

ignazio-bovo
Copy link
Contributor

addresses: #3702

@ignazio-bovo ignazio-bovo force-pushed the luxor/reward-curve-proposal branch from f69432c to ee37616 Compare March 13, 2024 11:22
mnaamani
mnaamani reviewed Mar 16, 2024
View reviewed changes
runtime-modules/council/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Show resolved Hide resolved
@thesan thesan mentioned this pull request Mar 25, 2024
Closed
@ignazio-bovo ignazio-bovo requested a review from mnaamani March 25, 2024 10:06
ignazio-bovo
ignazio-bovo commented Mar 25, 2024
View reviewed changes
Copy link
Contributor Author

@ignazio-bovo ignazio-bovo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I still have to add benchmarks for this but at this point I would wait before

  • Council reduce budget
  • Budget WG spending

@kdembler kdembler mentioned this pull request Mar 25, 2024
Open
This was referenced Mar 26, 2024
Closed
Closed
@kdembler
Copy link
Member

kdembler commented Mar 27, 2024 •
edited
Loading

Let's allow the multiplier to be 0.1-2.0. Mokhtar suggests to rename from damping to just multiplier

@kdembler kdembler requested a review from mnaamani March 29, 2024 10:00
@ignazio-bovo ignazio-bovo requested a review from mnaamani April 4, 2024 08:39
mnaamani
mnaamani approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@mnaamani mnaamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok LGTM.
Changes to runtime-upgrade integration test do not look complete and they will be addressed separately as per #5109

@mnaamani mnaamani merged commit 3580787 into Joystream:luxor Apr 4, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakstatic freakstatic freakstatic left review comments

@thesan thesan thesan left review comments

@mnaamani mnaamani mnaamani approved these changes

Assignees
No one assigned
Labels
luxor-network runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ignazio-bovo @kdembler @mnaamani @thesan @freakstatic