fix: 🐛 encoding issues with member handle (#214)

* fix: 🐛 encoding issues with member handle

* fix: 🐛 pr issues

* fix: 🐛 refactor and update changelog

* docs: update version number

CHANGELOG.md

@@ -1,3 +1,6 @@
+# 3.0.2
+### Bug Fixes:
+- Store membership handles both as utf-8 string and raw bytes - [#4950](https://github.com/Joystream/joystream/pull/4950)
 # 3.0.1
 ### Misc
 - add migration for the `Account` id field

package.json

@@ -1,6 +1,6 @@
 {
   "name": "orion",
-  "version": "3.0.1",
+  "version": "3.0.2",
   "engines": {
     "node": ">=16"
   },

schema/membership.graphql

@@ -31,8 +31,11 @@ type Membership @entity {
   "Timestamp of the block the membership was created at"
   createdAt: DateTime!
 
-  "The unique handle chosen by member"
-  handle: String! @unique
+  "The handle coming from decoded handleRaw if possible"
+  handle: String!
+
+  "The handle chosen by member coming from event deposit"
+  handleRaw: String! @unique
 
   "Member's metadata"
   metadata: MemberMetadata @derivedFrom(field: "member")

src/auth-server/tests/common.ts

@@ -121,11 +121,13 @@ export async function signedAction<T extends components['schemas']['ActionExecut
 
 async function insertFakeMember(controllerAccount: string) {
   const em = await globalEm
+  const handle = uniqueId()
   return em.getRepository(Membership).save({
     createdAt: new Date(),
     id: uniqueId(),
     controllerAccount,
     handle: uniqueId(),
+    handleRaw: '0x' + Buffer.from(handle).toString('hex'),
     totalChannelsCreated: 0,
   })
 }

src/mappings/membership/index.ts

@@ -1,3 +1,4 @@
+import { u8aToHex } from '@polkadot/util'
 import {
   Event,
   Membership,
@@ -20,16 +21,18 @@ export async function processNewMember({
   | 'Members.MembershipGifted'
 >) {
   const [memberId, params] = 'isV2001' in event && event.isV2001 ? event.asV2001 : event.asV1000
-  const { controllerAccount, handle, metadata: metadataBytes } = params
+  const { controllerAccount, handle: handleBytes, metadata: metadataBytes } = params
   const metadata = deserializeMetadata(MembershipMetadata, metadataBytes)
 
   const member = overlay.getRepository(Membership).new({
     createdAt: new Date(block.timestamp),
     id: memberId.toString(),
     controllerAccount: toAddress(controllerAccount),
-    handle: handle && bytesToString(handle),
     totalChannelsCreated: 0,
   })
+  if (handleBytes) {
+    updateMemberHandle(member as Membership, handleBytes)
+  }
 
   if (metadata) {
     await processMembershipMetadata(overlay, member.id, metadata)
@@ -57,7 +60,7 @@ export async function processMemberProfileUpdatedEvent({
   const member = await overlay.getRepository(Membership).getByIdOrFail(memberId.toString())
 
   if (newHandle) {
-    member.handle = newHandle.toString()
+    updateMemberHandle(member as Membership, newHandle)
   }
 
   if (newMetadata) {
@@ -68,6 +71,11 @@ export async function processMemberProfileUpdatedEvent({
   }
 }
 
+function updateMemberHandle(member: Membership, newHandle: Uint8Array) {
+  member.handleRaw = u8aToHex(newHandle)
+  member.handle = bytesToString(newHandle)
+}
+
 export async function processMemberRemarkedEvent({
   overlay,
   block,