feat: ⚡ batch channel verification

Joystream · Nov 24, 2023 · 4fd1948 · 4fd1948
1 parent 21fc5b0
commit 4fd1948
Show file tree

Hide file tree

Showing 2 changed files with 51 additions and 47 deletions.
diff --git a/src/server-extension/resolvers/ChannelsResolver/index.ts b/src/server-extension/resolvers/ChannelsResolver/index.ts
@@ -1,6 +1,6 @@
 import 'reflect-metadata'
 import { Args, Query, Mutation, Resolver, Info, Ctx, UseMiddleware } from 'type-graphql'
-import { EntityManager, IsNull } from 'typeorm'
+import { ArrayContains, EntityManager, IsNull } from 'typeorm'
 import {
   ChannelNftCollector,
   ChannelNftCollectorsArgs,
@@ -394,9 +394,9 @@ export class ChannelsResolver {
 
   @Mutation(() => VerifyChannelResult)
   @UseMiddleware(OperatorOnly())
-  async verifyChannel(@Args() { channelId }: VerifyChannelArgs): Promise<VerifyChannelResult> {
+  async verifyChannel(@Args() { channelIds }: VerifyChannelArgs): Promise<VerifyChannelResult[]> {
     const em = await this.em()
-    return await verifyChannelService(em, channelId)
+    return await verifyChannelService(em, channelIds)
   }
 
   @Mutation(() => ExcludeChannelResult)
@@ -468,51 +468,55 @@ export const excludeChannelService = async (
   })
 }
 
-export const verifyChannelService = async (em: EntityManager, channelId: string) => {
+export const verifyChannelService = async (em: EntityManager, channelIds: string[]) => {
   return withHiddenEntities(em, async () => {
-    const channel = await em.findOne(Channel, {
-      where: { id: channelId },
-    })
-
-    if (!channel) {
-      throw new Error(`Channel by id ${channelId} not found!`)
-    }
-    // If channel already verified - return its data
-    if (channel.yppStatus.isTypeOf === 'YppVerified') {
-      const existingVerification = await em.getRepository(ChannelVerification).findOneOrFail({
-        where: { channelId: channel.id },
-      })
-      return {
-        id: existingVerification.id,
-        channelId: channel.id,
-        createdAt: existingVerification.timestamp,
-      }
-    }
-    // othewise create new verification
-    const newVerification = new ChannelVerification({
-      id: uniqueId(),
-      channelId: channel.id,
-      timestamp: new Date(),
+    const channels = await em.getRepository(Channel).find({
+      where: { id: ArrayContains(channelIds) },
     })
-    channel.yppStatus = new YppVerified({ verification: newVerification.id })
-    await em.save([newVerification, channel])
 
-    // in case account exist deposit notification
-    const channelOwnerMemberId = channel.ownerMemberId
-    if (channelOwnerMemberId) {
-      const account = await em.findOne(Account, { where: { membershipId: channelOwnerMemberId } })
-      await addNotification(
-        em,
-        account,
-        new ChannelRecipient({ channel: channel.id }),
-        new ChannelVerified({})
-      )
-    }
+    const results = channels
+      .filter((channel) => channel)
+      .map(async (channel) => {
+        // If channel already verified - return its data
+        if (channel.yppStatus.isTypeOf === 'YppVerified') {
+          const existingVerification = await em.getRepository(ChannelVerification).findOneOrFail({
+            where: { channelId: channel.id },
+          })
+          return {
+            id: existingVerification.id,
+            channelId: channel.id,
+            createdAt: existingVerification.timestamp,
+          }
+        }
+        // othewise create new verification regardless whether the channel was previously verified
+        const newVerification = new ChannelVerification({
+          id: uniqueId(),
+          channelId: channel.id,
+          timestamp: new Date(),
+        })
+        channel.yppStatus = new YppVerified({ verification: newVerification.id })
+        await em.save([newVerification, channel])
+
+        // in case account exist deposit notification
+        const channelOwnerMemberId = channel.ownerMemberId
+        if (channelOwnerMemberId) {
+          const account = await em.findOne(Account, {
+            where: { membershipId: channelOwnerMemberId },
+          })
+          await addNotification(
+            em,
+            account,
+            new ChannelRecipient({ channel: channel.id }),
+            new ChannelVerified({})
+          )
+        }
 
-    return {
-      id: newVerification.id,
-      channelId: channel.id,
-      createdAt: newVerification.timestamp,
-    }
+        return {
+          id: newVerification.id,
+          channelId: channel.id,
+          createdAt: newVerification.timestamp,
+        }
+      })
+    return await Promise.all(results)
   })
 }
diff --git a/src/server-extension/resolvers/ChannelsResolver/types.ts b/src/server-extension/resolvers/ChannelsResolver/types.ts
@@ -186,8 +186,8 @@ export class SuspendChannelArgs {
 
 @ArgsType()
 export class VerifyChannelArgs {
-  @Field(() => String, { nullable: false })
-  channelId!: string
+  @Field(() => [String], { nullable: false })
+  channelIds!: string[]
 }
 
 @ObjectType()