-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Channel Weight (setChannelsWeights
) mutation
#232
Merged
ignazio-bovo
merged 10 commits into
Joystream:orion-v3.1.0
from
zeeshanakram3:set_channel_weight_mutation
Nov 14, 2023
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c375452
Add granular permissions support for Gateway operator users
zeeshanakram3 df8596a
fix lint issues
zeeshanakram3 2a34803
add mutation to set channel weight/bias for homepage video relevance
zeeshanakram3 683b813
revert docker-compose port change
zeeshanakram3 9204425
mark 'grantPermissions' & 'revokePermissions' input fields are non-nu…
zeeshanakram3 663ddad
Merge branch 'multi_level_permissions' into set_channel_weight_mutation
zeeshanakram3 b1a712f
bump package version
zeeshanakram3 36cd4ba
update global migration counter map
zeeshanakram3 e1f83ed
bumped package version & updated CHANGELOG
zeeshanakram3 26e28ee
Merge branch 'orion-v3.1.0' into set_channel_weight_mutation
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"name": "orion", | ||
"version": "3.0.4", | ||
"version": "3.1.0", | ||
"engines": { | ||
"node": ">=16" | ||
}, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering that now that we have permissions in place it might happens that there can be more than one user with the
SET_CHANNEL_WEIGHTS
permission and they might try to call this mutation at the same time.Should we consider locking for this (and possibly other mutations)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get your point but I don't think it's really necessary to lock the records, since locks have their own overhead, and they put all the future transactions affecting the record in
idle
state. which could have a drastic effect on performance (e.g. If we use lock in this mutation, then all the read/write operations by other mappings/queries/operations will be blocked until this operation is completed). Also, this specific transaction is only about updating a single field of the record, and even if there is any concurrent transaction affecting the record, at worst the channel weight update would fail, which I think is fine (as you would see that in the mutation response).Another important thing is that maybe we want to review all the
pessimistic_write
lock usage in queries/mutations and see if it's really required.