Feat/notifications update #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/processor.ts
Outdated
Comment on lines
381
to
387
| if (JOYSTREAM_USD_PRICE === null) { | ||
| await updateJoystreamPrice() | ||
| schedulePriceUpdate() | ||
| .then(() => undefined) | ||
| .catch(() => ctx.log.error('Fetching JOYSTREAM price failed')) | ||
| } | ||
|
|
There was a problem hiding this comment.
Just noticed that you are updating the JOYSTREAM_USD_PRICE in the orion_processor process, however, the value is being used in the email-scheduler cron job, where the value will always be null.
zeeshanakram3
requested changes
May 31, 2024
src/processor.ts
Outdated
Comment on lines
381
to
387
| if (JOYSTREAM_USD_PRICE === null) { | ||
| await updateJoystreamPrice() | ||
| schedulePriceUpdate() | ||
| .then(() => undefined) | ||
| .catch(() => undefined) | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| if (JOYSTREAM_USD_PRICE === null) { | |
| await updateJoystreamPrice() | |
| schedulePriceUpdate() | |
| .then(() => undefined) | |
| .catch(() => undefined) | |
| } |
It's not needed here now
malchililj
pushed a commit
to malchililj/orion
that referenced
this pull request
Sep 3, 2024
* Add joy price data * Change email notification subject copies * Decrease interval * CR fixes * remove scheduler from processor --------- Co-authored-by: Zeeshan Akram <97m.zeeshan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.