fix: remove duplicate CRT notifications creation

CHANGELOG.md

@@ -1,5 +1,11 @@
 # 4.0.4
 
+## Bug Fixes:
+- Fixed: avoiding IDs override/conflict while creating concurrent runtime notifications by reading/updating the `nextEntityId` from the `overlay` instead of DB - [#342](https://github.com/Joystream/orion/pull/342)
+- Fixed: removed possibility of creating duplicate CRT notifications in `processAmmActivatedEvent` and `processTokenSaleInitializedEvent` mappings if the account being notified is both channel follower as well as token holder - [#343](https://github.com/Joystream/orion/pull/343)
+
+# 4.0.4
+
 ## Bug Fixes:
 - Fixed: improve the accuracy of `Video.orionLanguage` field by reworking the `predictVideoLanguage` function in `src/utils/language.ts`
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "orion",
-  "version": "4.0.4",
+  "version": "4.0.5",
   "engines": {
     "node": ">=16"
   },

src/mappings/token/index.ts

@@ -54,6 +54,7 @@
   createAccount,
   getTokenAccountByMemberByToken,
   getTokenAccountByMemberByTokenOrFail,
+  notifyChannelFollowersAndTokenHolders,
   notifyTokenHolders,
   parseCreatorTokenSymbol,
   processTokenMetadata,
@@ -77,7 +78,7 @@
   },
 }: EventHandlerContext<'ProjectToken.TokenIssued'>) {
   // create token
   const totalSupply = initialAllocation.reduce((acc, [_, allocation]) => {
     return acc + allocation.amount
   }, BigInt(0))
 
@@ -248,8 +249,13 @@
     channelTitle: parseChannelTitle(channel),
   })
 
-  await notifyTokenHolders(overlay, tokenId.toString(), notificationData, eventEntity)
-  await notifyChannelFollowers(overlay, channel.id, notificationData, eventEntity)
+  await notifyChannelFollowersAndTokenHolders(
+    overlay,
+    channel.id,
+    tokenId.toString(),
+    notificationData,
+    eventEntity
+  )
 }
 
 export async function processTokenSaleInitializedEvent({
@@ -333,8 +339,13 @@
     channelTitle: parseChannelTitle(channel),
   })
 
-  await notifyTokenHolders(overlay, tokenId.toString(), notificationData, eventEntity)
-  await notifyChannelFollowers(overlay, channel.id, notificationData, eventEntity)
+  await notifyChannelFollowersAndTokenHolders(
+    overlay,
+    channel.id,
+    tokenId.toString(),
+    notificationData,
+    eventEntity
+  )
 }
 
 export async function processPatronageRateDecreasedToEvent({
@@ -387,7 +398,7 @@
     buyerAccount.totalAmount += crtMinted
   }
 
   const activeAmm = await overlay.getRepository(AmmCurve).getByIdOrFail(token.currentAmmSaleId!)
 
   activeAmm.mintedByAmm += crtMinted
   const tx = overlay.getRepository(AmmTransaction).new({
@@ -447,7 +458,7 @@
     .getOneByRelationOrFail('tokenId', tokenId.toString())
   const channel = await overlay.getRepository(Channel).getByIdOrFail(tokenChannel.channelId)
   token.totalSupply -= crtBurned
   const activeAmm = await overlay.getRepository(AmmCurve).getByIdOrFail(token.currentAmmSaleId!)
   const ammId = activeAmm.id
 
   const sellerAccount = await getTokenAccountByMemberByTokenOrFail(overlay, memberId, tokenId)
@@ -520,7 +531,7 @@
   }
 
   const token = await overlay.getRepository(CreatorToken).getByIdOrFail(tokenId.toString())
   const sale = await overlay.getRepository(Sale).getByIdOrFail(token.currentSaleId!)
   sale.tokensSold += amountPurchased
 
   const tx = overlay.getRepository(SaleTransaction).new({
@@ -580,7 +591,7 @@
   },
 }: EventHandlerContext<'ProjectToken.UpcomingTokenSaleUpdated'>) {
   const token = await overlay.getRepository(CreatorToken).getByIdOrFail(tokenId.toString())
   const sale = await overlay.getRepository(Sale).getByIdOrFail(token.currentSaleId!)
 
   if (newStart) {
     sale.startBlock = newStart
@@ -699,13 +710,13 @@
 export async function processAmmDeactivatedEvent({
   overlay,
   event: {
     asV2002: [tokenId, , burnedAmount],
   },
 }: EventHandlerContext<'ProjectToken.AmmDeactivated'>) {
   const token = await overlay.getRepository(CreatorToken).getByIdOrFail(tokenId.toString())
   token.status = TokenStatus.IDLE
 
   const activeAmm = await overlay.getRepository(AmmCurve).getByIdOrFail(token.currentAmmSaleId!)
   activeAmm.finalized = true
 
   token.currentAmmSaleId = null
@@ -744,12 +755,12 @@
   },
 }: EventHandlerContext<'ProjectToken.TokenSaleFinalized'>) {
   const token = await overlay.getRepository(CreatorToken).getByIdOrFail(tokenId.toString())
   const sale = await overlay.getRepository(Sale).getByIdOrFail(token.currentSaleId!)
   sale.finalized = true
 
   const sourceAccount = await overlay
     .getRepository(TokenAccount)
     .getByIdOrFail(sale.fundsSourceAccountId!)
   sourceAccount.totalAmount += quantityLeft
 
   token.status = TokenStatus.IDLE
@@ -785,7 +796,7 @@
   const token = await overlay.getRepository(CreatorToken).getByIdOrFail(tokenId.toString())
   const revenueShare = await overlay
     .getRepository(RevenueShare)
     .getByIdOrFail(token.currentRevenueShareId!)
   revenueShare.finalized = true
   token.currentRevenueShareId = null
 }

src/mappings/token/utils.ts

@@ -23,6 +23,7 @@ import { uniqueId } from '../../utils/crypto'
 import { criticalError } from '../../utils/misc'
 import { addNotification } from '../../utils/notification'
 import { EntityManagerOverlay, Flat } from '../../utils/overlay'
+import { getFollowersAccountsForChannel } from '../content/utils'
 
 export const FALLBACK_TOKEN_SYMBOL = '??'
 
@@ -366,3 +367,40 @@ export async function notifyTokenHolders(
     )
   )
 }
+
+export async function notifyChannelFollowersAndTokenHolders(
+  overlay: EntityManagerOverlay,
+  channelId: string,
+  tokenId: string,
+  notificationType: NotificationType,
+  event?: Event,
+  dispatchBlock?: number
+) {
+  const [followersAccounts, holderAccounts] = await Promise.all([
+    getFollowersAccountsForChannel(overlay, channelId),
+    getHolderAccountsForToken(overlay, tokenId),
+  ])
+
+  // Combine followers and holders, removing duplicates
+  const allAccounts = [...followersAccounts, ...holderAccounts]
+  const accounts = Array.from(new Set(allAccounts.map((a) => a.id)))
+    .map((id) => allAccounts.find((account) => account.id === id))
+    .filter((account): account is Account => account !== undefined)
+
+  const limit = pLimit(10) // Limit to 10 concurrent promises
+
+  await Promise.all(
+    accounts.map((account) =>
+      limit(() =>
+        addNotification(
+          overlay,
+          account,
+          new MemberRecipient({ membership: account.membershipId }),
+          notificationType,
+          event,
+          dispatchBlock
+        )
+      )
+    )
+  )
+}