Refactor TooltipExternalLink

[traumschule]

Tooltips with inline TooltipExternalLink produce bulky un-DRY code.

Replace TooltipExternalLink inside tooltipText with tooltipLinkURL on <Tooltip/>.

Problem

      tooltipText={
        <>
          Total rewards missed. Missed rewards are unallocated rewards from the council budget.{' '}
          <TooltipExternalLink
            href="https://joystream.gitbook.io/testnet-workspace/system/council?q=lock#budget"
            target="_blank"
          >
            <TextMedium>Learn more</TextMedium> <LinkSymbol />
          </TooltipExternalLink>
        </>

Solution

    <Tooltip
      tolltipTitle="Missed Rewards"
      tooltipText="Total rewards missed. Missed rewards are unallocated rewards from the council budget."
      tooltipLinkText="Learn more"
      tooltipLinkURL="https://joystream.gitbook.io/testnet-workspace/system/council?q=lock#budget"
    >
      <TooltipDefault />
    </Tooltip>

Occurences

1. https://github.com/Joystream/pioneer/blob/dev/packages/ui/src/memberships/modals/BuyMembershipModal/BuyMembershipFormModal.tsx#L270
2. https://github.com/Joystream/pioneer/blob/dev/packages/ui/src/bounty/modals/AddBountyModal/components/FundingDetailsStep.tsx#L52
3. https://github.com/Joystream/pioneer/blob/dev/packages/ui/src/proposals/modals/AddNewProposal/components/ExecutionRequirementsWarning.tsx#L20
4. https://github.com/Joystream/pioneer/blob/dev/packages/ui/src/proposals/modals/AddNewProposal/components/StakingAccountStep.tsx#L37
5. https://github.com/Joystream/pioneer/blob/dev/packages/ui/src/proposals/modals/AddNewProposal/components/SpecificParameters/SetReferralCut.tsx#L39
6. https://github.com/Joystream/pioneer/blob/dev/packages/ui/src/proposals/modals/AddNewProposal/components/SpecificParameters/WorkingGroupLeadOpening/CreateWorkingGroupLeadOpening/StakingPolicyAndReward.tsx#L48
7. https://github.com/Joystream/pioneer/blob/dev/packages/ui/src/accounts/components/StakeStep.tsx#L61
8. https://github.com/Joystream/pioneer/blob/dev/packages/ui/src/memberships/modals/InviteMemberModal/InviteMemberFormModal.tsx#L159https://github.com/Joystream/pioneer/blob/dev/packages/ui/src/bounty/modals/ContributeFundsModal/ContributeFundsModal.tsx#L210

Out of Scope

• https://github.com/Joystream/pioneer/blob/ab7b03cd9b068e01e9f383b0a0c89dd9fd8d402e/packages/ui/src/memberships/modals/InviteMemberModal/InviteMemberRequirementsModal.tsx
• https://github.com/Joystream/pioneer/blob/dev/packages/ui/src/accounts/components/SelectAccount/AccountLockTooltip.tsx

[ivanturlakov]

Tested on https://dao-git-staging-joystream.vercel.app/
wss://34.230.5.182.nip.io/ws-rpc

For problematic cases, I created separate issues

✅ packages/ui/src/memberships/modals/BuyMembershipModal/BuyMembershipFormModal.tsx

✅ packages/ui/src/bounty/modals/AddBountyModal/components/FundingDetailsStep.tsx

✅ packages/ui/src/proposals/modals/AddNewProposal/components/StakingAccountStep.tsx

✅ packages/ui/src/proposals/modals/AddNewProposal/components/SpecificParameters/SetReferralCut.tsx

✅ packages/ui/src/proposals/modals/AddNewProposal/components/SpecificParameters/WorkingGroupLeadOpening/CreateWorkingGroupLeadOpening/StakingPolicyAndReward.tsx

⚠️ packages/ui/src/accounts/components/StakeStep.tsx

⚠️ packages/ui/src/memberships/modals/InviteMemberModal/InviteMemberFormModal.tsx

✅ packages/ui/src/bounty/modals/ContributeFundsModal/ContributeFundsModal.tsx

✅ packages/ui/src/memberships/modals/BuyMembershipModal/BuyMembershipSignModal.tsx