Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LInk to Calamar from Block links in the app #4397

Closed
dmtrjsg opened this issue May 30, 2023 · 5 comments
Closed

LInk to Calamar from Block links in the app #4397

dmtrjsg opened this issue May 30, 2023 · 5 comments
Assignees
Labels

Comments

@dmtrjsg
Copy link
Contributor

dmtrjsg commented May 30, 2023

We have a few places in the app where a particular block links to polkadot. Suggestion to swap this to Calamar explorer instead.

Screenshot 2023-05-30 at 12.12.48.png

@bedeho
Copy link
Member

bedeho commented May 30, 2023

Very good idea, just make sure this is configurable, so that changing url for different kinds of resources does not requre actually making code changes.

@dmtrjsg
Copy link
Contributor Author

dmtrjsg commented May 30, 2023

Let's add this option to the settings @thesan ? :)

@bedeho
Copy link
Member

bedeho commented May 30, 2023

You can't add this to setings in any convenient way, because the schema for how to access different resources: blocks, accountss, transctions, etc., it entirely depends on the service type, not the specific host. So if one day Calamar did not exist, and Subscan was going to be used, the urls for accessing different type resources would likely be different.

@thesan
Copy link
Member

thesan commented Jun 1, 2023

Calamar seems to still have some rough edges like not showing event parameters, also #4401 (review). So even though I had suggested this, now I think we should probably keep the Polkadot app for block links for now.

@dmtrjsg
Copy link
Contributor Author

dmtrjsg commented Jun 5, 2023

Calamar is great if you don't know the block number, due to good search.. but if you know the block number - Polkadot app has more information on it. So this issue does not make sense to ship as of yet. Adding to Icebox before more info appears on Calamar for known blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants