Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🦑 Add a link to the Calamar block explorer #4401

Merged
merged 1 commit into from
Jun 1, 2023
Merged

🦑 Add a link to the Calamar block explorer #4401

merged 1 commit into from
Jun 1, 2023

Conversation

thesan
Copy link
Member

@thesan thesan commented May 31, 2023

@vercel
Copy link

vercel bot commented May 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview May 31, 2023 6:30pm
pioneer-2 ✅ Ready (Inspect) Visit Preview May 31, 2023 6:30pm
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview May 31, 2023 6:30pm

traumschule
traumschule approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@traumschule traumschule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Using Tor calamar console shows:

POST https://joystream.explorer.subsquid.io/graphql net::ERR_FAILED

Error: Forbidden
Your client does not have permission to get URL /graphql from this server.

@thesan
Copy link
Member Author

thesan commented Jun 1, 2023

LGTM.

Using Tor calamar console shows:

POST https://joystream.explorer.subsquid.io/graphql net::ERR_FAILED

Error: Forbidden
Your client does not have permission to get URL /graphql from this server.

Good to know. I thinks it's good to provide Calamar as an option since it makes it a lot easier to find transactions/events but it still need a lot of improvement. The Polkadot app should stay in the menu and remain the explorer used whenever Pioneer refers to a given block for now.

@thesan thesan mentioned this pull request Jun 1, 2023
Closed
@thesan thesan merged commit e78a75a into dev Jun 1, 2023
@thesan thesan deleted the feature/calamar branch June 1, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traumschule traumschule traumschule approved these changes

@chrlschwb chrlschwb Awaiting requested review from chrlschwb

Assignees
No one assigned
Labels
builders-wg-code-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thesan @traumschule