🚲 Cycle candidates #1584
Closed
🚲 Cycle candidates #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodator
suggested changes
Oct 4, 2021
| <CopyButtonTemplate | ||
| square | ||
| size="small" | ||
| textToCopy={`${window.location.host}/#/members/${candidate?.member.id}`} |
There was a problem hiding this comment.
Wrong link to candidacy. I don't think we have a separate issue (but you might search for one).
There was a problem hiding this comment.
I haven't found any issue that relates to this, and I think it might deserve its own issue. I think link to member preview had one.
There was a problem hiding this comment.
So let's create a separate issue for handling links to candidates.
jodator
reviewed
Oct 5, 2021
| <CopyButtonTemplate | ||
| square | ||
| size="small" | ||
| textToCopy={`${window.location.host}/#/members/${candidate?.member.id}`} |
There was a problem hiding this comment.
So let's create a separate issue for handling links to candidates.
|
Closing because a github outage prevents the last 3 commits from showing up in the PR |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1388
Potentially closes this issue; I'm not sure though, because I don't really understand what "preview mode" is.