🍉 Handle summary and candidacy previews for announce candidacy #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-olizarenko
force-pushed
the
announce-candidacy-description
branch
from
0111b4d to
e6b9348
Compare
jodator
suggested changes
Oct 7, 2021
There was a problem hiding this comment.
First of all this PR is too broad as it covers 3 separate issues. It takes some time to process that and there might be many aspects to look at in each of the steps.
At least adding the preview buttons should be done as a separate PR.
I think that it would be better to start working on the comments for the part covering #1405 so starting from 608c9c3 commit. Then, on top of that, you can work on changes for #1406 & #1407.
packages/ui/src/council/modals/AnnounceCandidacy/components/CandidacyProfilePreview.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/council/components/election/CandidateCard/CandidateCard.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/memberships/components/MemberProfile/MemberModal.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/memberships/components/MemberProfile/MemberModal.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/council/modals/AnnounceCandidacy/AnnounceCandidacyModal.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/council/modals/AnnounceCandidacy/AnnounceCandidacyModal.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/council/modals/AnnounceCandidacy/components/CandidacyThumbnailPreview.tsx
Show resolved
Hide resolved
packages/ui/src/council/components/election/CandidateCard/CandidateCard.tsx
Show resolved
Hide resolved
jodator
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1406
Closes #1407
Closes #1405