Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👨‍🚀 POC - Form vendor #2836

Merged
merged 9 commits into from
Apr 13, 2022
Merged

👨‍🚀 POC - Form vendor #2836

merged 9 commits into from
Apr 13, 2022

Conversation

WRadoslaw
Copy link
Contributor

@WRadoslaw WRadoslaw commented Apr 10, 2022 •
edited by dmtrjsg
Loading

@vercel
Copy link

vercel bot commented Apr 10, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

pioneer-2 – ./

🔍 Inspect: https://vercel.com/joystream/pioneer-2/FhWPnEATGoQBHxXWXptQfwtmoR7D
✅ Preview: https://pioneer-2-git-poc-form-vendor-joystream.vercel.app

pioneer-2-storybook – ./

🔍 Inspect: https://vercel.com/joystream/pioneer-2-storybook/Daf3p5JNroy21uxxWogwRD5DA4Qm
✅ Preview: https://pioneer-2-storybook-git-poc-form-vendor-joystream.vercel.app

dao – ./

🔍 Inspect: https://vercel.com/joystream/dao/HkGfiV9VXrQxkKB36Y6YGk7dqtii
✅ Preview: https://dao-git-poc-form-vendor-joystream.vercel.app

thesan
thesan requested changes Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good but I would prefer replacing "Controlled" by something else e.g RFH

thesan
thesan approved these changes Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very impressive PR again 💪
Thanks

@WRadoslaw WRadoslaw merged commit 6c4dba7 into dev Apr 13, 2022
@WRadoslaw WRadoslaw deleted the POC/form-vendor branch April 13, 2022 06:52
@WRadoslaw WRadoslaw mentioned this pull request Apr 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesan thesan thesan approved these changes

@stepien4soft stepien4soft Awaiting requested review from stepien4soft

Assignees

@thesan thesan

@stepien4soft stepien4soft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WRadoslaw @thesan @stepien4soft