-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🗳️ Fix past votes stake recovering #2855
Conversation
This pull request is being automatically deployed with Vercel (learn more). pioneer-2 – ./🔍 Inspect: https://vercel.com/joystream/pioneer-2/DLGtpXtKAQQjr87H7AzGZumb9uQN pioneer-2-storybook – ./🔍 Inspect: https://vercel.com/joystream/pioneer-2-storybook/G32K2nfAzV8XQkRMQrGwYYAazjHH dao – ./🔍 Inspect: https://vercel.com/joystream/dao/CkPmP8FwmNbuyMsZ4D8V2N6gfyXZ |
|
packages/ui/src/council/components/PastVotes/PastVote/PastVote.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really sorry about the long review delay on this.
In addition to the other comments please:
- To have this work: uncomment the
isCouncilMember
anddata.isCouncilMember
in@/memberships/queries/members.graphql
(and remove the# See https://github.com/Joystream/pioneer/issues/1536
) and@/memberships/types/casting
- This is a bit off topic but as a result of (1): Remove the
useCouncilMember
hook and replace each time it's called by e.gmember.isCouncilMember
packages/ui/src/council/components/PastVotes/PastVote/PastVote.tsx
Outdated
Show resolved
Hide resolved
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for fixing extra stuff in this PR. And also cutting it in small commits that really helped me 🙌
Closes #2834