Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗳️ Fix past votes stake recovering #2855

Merged
merged 12 commits into from
Apr 24, 2022

Conversation

RafalPloszka
Copy link
Contributor

Closes #2834

@vercel
Copy link

vercel bot commented Apr 13, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

pioneer-2 – ./

🔍 Inspect: https://vercel.com/joystream/pioneer-2/DLGtpXtKAQQjr87H7AzGZumb9uQN
✅ Preview: https://pioneer-2-git-fix-recovering-past-votes-stake-joystream.vercel.app

pioneer-2-storybook – ./

🔍 Inspect: https://vercel.com/joystream/pioneer-2-storybook/G32K2nfAzV8XQkRMQrGwYYAazjHH
✅ Preview: https://pioneer-2-storybook-git-fix-recovering-past-vo-82b0f2-joystream.vercel.app

dao – ./

🔍 Inspect: https://vercel.com/joystream/dao/CkPmP8FwmNbuyMsZ4D8V2N6gfyXZ
✅ Preview: https://dao-git-fix-recovering-past-votes-stake-joystream.vercel.app

@RafalPloszka
Copy link
Contributor Author

⚠️ Important note: This PR also fixes hardcoded isCouncilMember: false (by using a hook instead) in #2363

@RafalPloszka RafalPloszka requested a review from thesan April 14, 2022 12:53
Copy link
Collaborator

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really sorry about the long review delay on this.

In addition to the other comments please:

  1. To have this work: uncomment the isCouncilMember and data.isCouncilMember in @/memberships/queries/members.graphql (and remove the # See https://github.com/Joystream/pioneer/issues/1536) and @/memberships/types/casting
  2. This is a bit off topic but as a result of (1): Remove the useCouncilMember hook and replace each time it's called by e.g member.isCouncilMember

@vercel
Copy link

vercel bot commented Apr 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dao ✅ Ready (Inspect) Visit Preview Apr 22, 2022 at 6:46AM (UTC)
pioneer-2 ✅ Ready (Inspect) Visit Preview Apr 22, 2022 at 6:46AM (UTC)
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Apr 22, 2022 at 6:46AM (UTC)

Copy link
Collaborator

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing extra stuff in this PR. And also cutting it in small commits that really helped me 🙌

@RafalPloszka RafalPloszka merged commit 9cac43b into dev Apr 24, 2022
@RafalPloszka RafalPloszka deleted the fix/recovering-past-votes-stake branch April 24, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[USERSNAP] My Profile" Recover opens past-votes for Vote Stakes
2 participants