Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

😶‍🌫️ Cosmetic fixes on announce work modal #2931

Merged
merged 4 commits into from
Apr 29, 2022
Merged

😶‍🌫️ Cosmetic fixes on announce work modal #2931

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8d96f6f
Fixes on AnnounceWorkEntryModal
WRadoslaw Apr 25, 2022
f08be7e
Tooltip added
WRadoslaw Apr 25, 2022
e3089ec
Test fix
WRadoslaw Apr 28, 2022
b7c5665
Merge branch 'dev' into fix/cosmetic-fixes-announce-work-modal
WRadoslaw Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/ui/src/bounty/modals/AnnounceWorkEntryModal/AnnounceWorkEntryModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ export const AnnounceWorkEntryModal = () => {
}

return (
<Modal onClose={hideModal} modalSize="l">
<Modal onClose={hideModal} modalSize="m">
<ModalHeader title={t('modals.announceWorkEntry.title')} onClick={hideModal} />
<ScrolledModalBody>
<ScrolledModalContainer>
Expand All @@ -210,7 +210,7 @@ export const AnnounceWorkEntryModal = () => {
required
inputDisabled
>
<ReadOnlyInput value={bounty.id} readOnly />
<ReadOnlyInput value={bounty.title} readOnly />
</InputComponent>
</Row>
<Row>
Expand Down Expand Up @@ -253,6 +253,7 @@ export const AnnounceWorkEntryModal = () => {
inputWidth="s"
units="tJOY"
disabled
tooltipText={t('modals.announceWorkEntry.selectAmountTooltip')}
>
<InputNumber id="amount-input" value={amount.toString()} isTokenValue disabled />
</InputComponent>
Expand Down
5 changes: 3 additions & 2 deletions packages/ui/src/services/i18n/dict/en/bounty.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,9 @@
"tooltip": "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua."
},
"fillDetails": "Please fill in all the details below.",
"selectAmount": "Contribution stake",
"selectAmountSubtitle": "This stake will be returned to you when the bounty is complete",
"selectAmount": "Entrant stake",
"selectAmountSubtitle": "Entrant stake is returned to your account automatically, when bounty is finished.",
"selectAmountTooltip": "Minimum entrant stake is defined by the bounty creator.",
"authorizeDescription": "You intend to Apply for a bounty. You intend to stake {{value}} tJOY.",
"error": "Something went wrong",
"success": "You have just successfully announce work entry for ”{{bounty}}”.",
Expand Down
4 changes: 2 additions & 2 deletions packages/ui/test/bounty/modals/AnnounceWorkEntryModal.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ describe('UI: AnnounceWorkEntryModal', () => {
expect(screen.getByText('modals.announceWorkEntry.title')).toBeInTheDocument()
})

it('Displays correct bounty id', () => {
expect(screen.getByDisplayValue(bounty.id)).toBeInTheDocument()
it('Displays correct bounty title', () => {
expect(screen.getByDisplayValue(bounty.title)).toBeInTheDocument()
})

it('Displays correct member', () => {
Expand Down