Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Candidates Card "Staked" copy #3338

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Fix Candidates Card "Staked" copy #3338

merged 2 commits into from
Jul 22, 2022

Conversation

BeardKoda
Copy link
Contributor

@BeardKoda BeardKoda commented Jul 8, 2022 •
edited by thesan
Loading

#2795

  • My stake on candidate stake to be renamed to "Staked"

@vercel
Copy link

vercel bot commented Jul 8, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dao ✅ Ready (Inspect) Visit Preview Jul 22, 2022 at 10:04AM (UTC)
pioneer-2 ✅ Ready (Inspect) Visit Preview Jul 22, 2022 at 10:04AM (UTC)
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Jul 22, 2022 at 10:04AM (UTC)

@thesan thesan added the community-dev issue suitable for community-dev pipeline label Jul 11, 2022
@freakstatic
Copy link
Collaborator

Hi @BeardKoda!
Thanks for the PR, LGTM! 👍

@singulart
Copy link
Contributor

@thesan Please review, ideally in the upcoming hours. Trying to close the Term with positive result :) Thanks in advance!

@singulart singulart requested a review from thesan July 20, 2022 06:43
@singulart
Copy link
Contributor

@thesan This is still needs to be reviewed, thank you!

WRadoslaw
WRadoslaw approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@WRadoslaw WRadoslaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👏

@WRadoslaw WRadoslaw added the waiting-for-checks PR is reviewed and approved, but is waiting for checks to complete label Jul 21, 2022
@thesan
Copy link
Collaborator

thesan commented Jul 21, 2022

@singulart, @BeardKoda sorry I've been really late on the PR review lately.
@BeardKoda please could you change the failing test in test/council/pages/Election.test.tsx:
From: expect(queryAllByText(/my stake/i).length).toBe(1)
To: expect(queryAllByText(/Staked/i).length).toBe(1)

@thesan thesan removed the waiting-for-checks PR is reviewed and approved, but is waiting for checks to complete label Jul 21, 2022
@thesan thesan changed the title Fix: https://github.com/Joystream/pioneer/issues/2795 Fix Candidates Card "Staked" copy Jul 21, 2022
@thesan thesan assigned BeardKoda and unassigned thesan Jul 21, 2022
@freakstatic freakstatic mentioned this pull request Jul 22, 2022
Closed
1 task
@thesan thesan added the waiting-for-checks PR is reviewed and approved, but is waiting for checks to complete label Jul 22, 2022
@thesan thesan merged commit ec23c4f into Joystream:dev Jul 22, 2022
@thesan thesan removed the waiting-for-checks PR is reviewed and approved, but is waiting for checks to complete label Jul 22, 2022
thesan added a commit that referenced this pull request Oct 6, 2022
@thesan @Palllke2015
@PHliebov @BeardKoda @WRadoslaw @mkbeefcake
Release Stabilisation Bugfixing 10 (#3641)
0214ffa 
* 🪅 add word break (#3326)

* add word break

* add word-wrap for title

Co-authored-by: Pasha Hliebov <p.hliebov@bsg.world>

* 🥩 Fix Candidates Card "Staked" copy (#3338)

* Fix: #2795

* Fix: Test Fix

* 🔌 Refactor the api to easily switch between `ProxyApi` and `ApiRx` (#3385)

Refactor `@/api`

* ⏲️ Fix election/council remaining period timer (#3444)

* Fix election/council remaining period clock

* Fix tests

* Fix one more test

* 👮 Show moderated posts (#3420)

* feat: Show moderated posts

* fix: Moderated post stories args

* fix: useForumThreadPosts error

* ⚖️ Fix available staking balances (#3408)

* New function to calc available balance for staking account

* Apply of the new function

* Small UI tweaks

* Fix for same keys in bounty actors list

* Update the SelectAccount balances

* Update the getStakingBalance logic

* Speed up `useMyBalances`

* Fix the validation

* Updating logic and corresponding UI

* Always validate `balances.total` for staking

* Validate AnnounceCandidacy including binding fees

* Validate staking amounts including binding fee

* Fix the ApplyForRoleModal tests

Co-authored-by: WRadoslaw <r.wyszynski00@gmail.com>

* 🗳️ Add a `node-mocks council:elect` for testing node (#3410)

Add a `node-mocks council:elect` for testing node

* 📄 Signal description copy change (#3193)

* Update for staking amount validate

* Fiexed:issue 3091

* update for issue 2770

* Reverse #2601 and #2770 fixes

Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>

* 🧵 Fixed datetime is not displayed for Forum thread (#3574)

* Fixed datetime is not displayed for Forum thread

* changed graphql for forumthreadinitialpost

* removed unnecessary fields

* changed quorum bar with council's size (#3595)

* changed quorum bar with council's size

fixed concilsize to denominator

fixed

used abstain for quorum & thresold

added remain and abstain bar

* added abstain slider in storybook

Co-authored-by: Palllke2015 <palllke2015@gmail.com>
Co-authored-by: Pasha Hliebov <p.hliebov@bsg.world>
Co-authored-by: Akinsuyi Joshua <akinsuyi.joshua84@gmail.com>
Co-authored-by: gyroflaw <83718263+gyroflaw@users.noreply.github.com>
Co-authored-by: WRadoslaw <r.wyszynski00@gmail.com>
Co-authored-by: Ken-tech-max <81464477+Ken-tech-max@users.noreply.github.com>
Co-authored-by: Software Developer | Web, Blockchain & Desktop <69617937+mkbeefcake@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WRadoslaw WRadoslaw WRadoslaw approved these changes

@thesan thesan Awaiting requested review from thesan

Assignees

@BeardKoda BeardKoda

Labels
community-dev issue suitable for community-dev pipeline jsg-code-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BeardKoda @freakstatic @singulart @thesan @WRadoslaw