Invitation lock tooltip (#3479) #3740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
traumschule
added
community-dev
WRadoslaw
reviewed
Oct 24, 2022
| @@ -111,7 +113,7 @@ export const BuyMembershipSignModal = ({ | |||
| <TransactionInfo | |||
| title="Creation fee:" | |||
| value={membershipPrice?.toBn()} | |||
| tooltipText={'Lorem ipsum dolor sit amet consectetur, adipisicing elit.'} | |||
| tooltipText={'The price to create a membership.'} | |||
There was a problem hiding this comment.
Suggested change
| tooltipText={'The price to create a membership.'} | |
| tooltipText="The price to create a membership." |
There was a problem hiding this comment.
That would be nice to have before merge
There was a problem hiding this comment.
Fixed in #3775.
|
@dmtrjsg I don't see any issue for this tooltip change, please feel free to take a look and approve if everything is good |
traumschule
commented
Oct 25, 2022
packages/ui/src/memberships/modals/BuyMembershipModal/BuyMembershipSignModal.tsx
Show resolved
Hide resolved
|
LGTM! |
WRadoslaw
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3479
Took the liberty to also address
Creation fee.