Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display whitelisted members for closed proposal discussions (#2480) #3756

Merged
merged 5 commits into from
Dec 12, 2022
Merged

Display whitelisted members for closed proposal discussions (#2480) #3756

merged 5 commits into from
Dec 12, 2022

Conversation

traumschule
Copy link
Collaborator

@traumschule traumschule commented Oct 25, 2022 •
edited
Loading

Fixes #2480

Test fixed too except

Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?
        at fn (/home/debian/pioneer/packages/ui/test/proposals/components/ProposalDiscussion.test.tsx:20:45)

Idea: Whitelisted members could also be listed with MemberInfo and modal / drawer.

@vercel
Copy link

vercel bot commented Oct 25, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dao ✅ Ready (Inspect) Visit Preview Dec 8, 2022 at 7:39PM (UTC)
pioneer-2 ✅ Ready (Inspect) Visit Preview Dec 8, 2022 at 7:39PM (UTC)
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Dec 8, 2022 at 7:39PM (UTC)

@thesan thesan added the community-dev issue suitable for community-dev pipeline label Oct 28, 2022
@traumschule traumschule marked this pull request as ready for review November 18, 2022 06:48
@traumschule traumschule requested a review from thesan November 19, 2022 01:44
oleksanderkorn
oleksanderkorn approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@oleksanderkorn oleksanderkorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thesan
thesan approved these changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thesan thesan merged commit 3272196 into Joystream:dev Dec 12, 2022
XxFlameCatxX pushed a commit to XxFlameCatxX/pioneer that referenced this pull request Dec 27, 2022
@traumschule @XxFlameCatxX
Display whitelisted members for closed proposal discussions (Joystrea…
18c3564 
…m#2480) (Joystream#3756)

* Display whitelisted members for closed proposal discussions (Joystream#2480)

* fixup

* fix ProposalDiscussion.test.tsx

* change wording, fix test

Co-authored-by: Joystream Stats <dev@joystreamstats.live>
XxFlameCatxX pushed a commit to XxFlameCatxX/pioneer that referenced this pull request Jan 14, 2023
@traumschule @XxFlameCatxX
Display whitelisted members for closed proposal discussions (Joystrea…
b1abc18 
…m#2480) (Joystream#3756)

* Display whitelisted members for closed proposal discussions (Joystream#2480)

* fixup

* fix ProposalDiscussion.test.tsx

* change wording, fix test

Co-authored-by: Joystream Stats <dev@joystreamstats.live>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksanderkorn oleksanderkorn oleksanderkorn approved these changes

@thesan thesan thesan approved these changes

Assignees
No one assigned
Labels
community-dev issue suitable for community-dev pipeline jsg-code-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[USERSNAP] Proposals: Closed Discussion mode does not indicate who is on the whitelist
3 participants
@traumschule @thesan @oleksanderkorn