Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stake changed Activities (#3458) #3826

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Stake changed Activities (#3458) #3826

merged 1 commit into from
Dec 12, 2022

Conversation

traumschule
Copy link
Collaborator

Fixes #3458 (comment)

  • Add 'Read more' on StakeSlashedContent to open StakeChangedModal
  • Rename Slashed By with' to Amount
  • Rename Status with Action
  • Hide Amount if empty
  • Hide Rationale if empty

Note: To display more slashing details on the modal the activity object / QN fragment is missing: slashedAmount suggestedAmount rationale
slashed

query { 
  stakeSlashedEvents { id inBlock createdAt groupId slashedAmount requestedAmount rationale worker { membershipId } }
  stakeDecreasedEvents { id inBlock createdAt groupId amount worker { membershipId } }
  stakeIncreasedEvents { id inBlock createdAt groupId amount worker { membershipId } }
  stakeReleasedEvents { id inBlock createdAt stakingAccount }
}

https://44.201.112.198.nip.io/query-node/server/graphql

Stake changed Activities (Joystream#3458)
9839372 
 - Add 'Read more' on `StakeSlashedContent` to open `StakeChangedModal`
 - Rename 'Slashed with' to 'Amount'
 - Rename 'Status' with 'Action'
 - Hide Amount if empty
 - Hide Rationale if empty
@vercel
Copy link

vercel bot commented Nov 10, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dao ✅ Ready (Inspect) Visit Preview Nov 10, 2022 at 4:10PM (UTC)
pioneer-2 ✅ Ready (Inspect) Visit Preview Nov 10, 2022 at 4:10PM (UTC)
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Nov 10, 2022 at 4:10PM (UTC)

@traumschule traumschule added community-dev issue suitable for community-dev pipeline builders-wg-code-review labels Nov 10, 2022
@traumschule
Copy link
Collaborator Author

timeout on unrelated tests

@traumschule traumschule mentioned this pull request Dec 8, 2022
Closed
@traumschule traumschule closed this Dec 8, 2022
@traumschule traumschule reopened this Dec 8, 2022
oleksanderkorn
oleksanderkorn approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@oleksanderkorn oleksanderkorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thesan thesan merged commit 6afd081 into Joystream:dev Dec 12, 2022
XxFlameCatxX pushed a commit to XxFlameCatxX/pioneer that referenced this pull request Dec 27, 2022
@traumschule @XxFlameCatxX
Stake changed Activities (Joystream#3458) (Joystream#3826)
889a791 
- Add 'Read more' on `StakeSlashedContent` to open `StakeChangedModal`
 - Rename 'Slashed with' to 'Amount'
 - Rename 'Status' with 'Action'
 - Hide Amount if empty
 - Hide Rationale if empty

Co-authored-by: Joystream Stats <dev@joystreamstats.live>
XxFlameCatxX pushed a commit to XxFlameCatxX/pioneer that referenced this pull request Jan 14, 2023
@traumschule @XxFlameCatxX
Stake changed Activities (Joystream#3458) (Joystream#3826)
d306382 
- Add 'Read more' on `StakeSlashedContent` to open `StakeChangedModal`
 - Rename 'Slashed with' to 'Amount'
 - Rename 'Status' with 'Action'
 - Hide Amount if empty
 - Hide Rationale if empty

Co-authored-by: Joystream Stats <dev@joystreamstats.live>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesan thesan thesan approved these changes

@oleksanderkorn oleksanderkorn oleksanderkorn approved these changes

Assignees
No one assigned
Labels
community-dev issue suitable for community-dev pipeline jsg-code-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide rationale from Slash and Decrease WGL stake details.
3 participants
@traumschule @thesan @oleksanderkorn