Show new invitation quota on ProposalDetails (#3902)

[traumschule]

Fixes #3902

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
dao	✅ Ready (Inspect)	Visit Preview	Dec 8, 2022 at 9:59PM (UTC)
pioneer-2	✅ Ready (Inspect)	Visit Preview	Dec 8, 2022 at 9:59PM (UTC)
pioneer-2-storybook	✅ Ready (Inspect)	Visit Preview	Dec 8, 2022 at 9:59PM (UTC)

[oleksanderkorn]

@traumschule what do you mean by parameter doesn't show up. ?
I see it on the preview branch:

Oh you mean in the created proposal.. nvm :) checking

[oleksanderkorn]

@traumschule the proposalDetails are not defined for such type:

The trick is the missing definition of SetMembershipLeadInvitationQuotaDetails:

See for example const asSetReferralCut: DetailsCast<'SetReferralCutProposalDetails'> = (fragment): SetReferralCutDetails => ({
It is autogenerated from graphql schema, same should be done here for our type setMembershipLeadInvitationQuota

[oleksanderkorn]

[oleksanderkorn]

@traumschule check this out https://github.com/traumschule/pioneer/pull/4/files :)

[traumschule]

Thanks!

[oleksanderkorn]

If we change type to count should it also be the count on proposal creation? Because currently this is treat as amount:

[traumschule]

FAIL test/proposals/modals/AddNewProposalModal.test.tsx (307.649 s)
 |   ● UI: AddNewProposalModal › Stepper modal › Specific parameters › Type - Set Membership lead invitation quota proposal › Valid form
 | 
 |     expect(received).toEqual(expected) // deep equality
 | 
 |     Expected: 100
 |     Received: 0
 | 
 |       1006 |           const [, txSpecificParameters] = last(createProposalTxMock.mock.calls)
 |       1007 |           const parameters = txSpecificParameters.asSetMembershipLeadInvitationQuota.toJSON()
 |     > 1008 |           expect(parameters).toEqual(amount)

[thesan]

LGTM but I don't really understand how it fixes #3902 😕

[traumschule]

the key was to cast the detail