Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Languages tab (#3955) #3964

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Conversation

traumschule
Copy link
Collaborator

Fixes #3955

@vercel
Copy link

vercel bot commented Dec 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dao ✅ Ready (Inspect) Visit Preview Dec 9, 2022 at 4:11PM (UTC)
pioneer-2 ✅ Ready (Inspect) Visit Preview Dec 9, 2022 at 4:11PM (UTC)
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Dec 9, 2022 at 4:11PM (UTC)

Copy link
Contributor

@oleksanderkorn oleksanderkorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought, should we remove it instead of commenting out?
We can put it back after from git history when its needed.

Copy link
Collaborator

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oleksanderkorn I agree that deleting the code would be better (and it would be easy to find back on a small file like this one). But then there are already a bunch of commented out code on the app so it's fine for now. Maybe we could clean those out later.

@thesan thesan merged commit 846d2a1 into Joystream:dev Dec 21, 2022
XxFlameCatxX pushed a commit to XxFlameCatxX/pioneer that referenced this pull request Jan 14, 2023
Co-authored-by: Joystream Stats <dev@joystreamstats.live>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-dev issue suitable for community-dev pipeline jsg-code-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide Languages tab from Settings
3 participants