-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed subcategory layout #3984
base: dev
Are you sure you want to change the base?
fixed subcategory layout #3984
Conversation
@mkbeefcake is attempting to deploy a commit to the joystream Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
items={category.subcategories.map((category) => ( | ||
<CategoryCard key={category.id} category={category} /> | ||
))} | ||
count={category.subcategories.length} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
design shows 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed this problem and updated it. please check it again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is according to design but depending on category titles and descriptions it looks pretty empty. maybe 3 or 4 will fit as well. leaving this up to further review. thanks @mkbeefcake!
My pleasure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it wasn't very clear in the design (because it shows only 2 categories) but what we meant was to display the categories in a grid, just like how they look on the forum home page:
Not in a in a slider.
As a result a some components will become unused: <ForumCategoryList/>
<CategoryListItem />
, and maybe some others... Please remove them in this PR (as well as there stories if need).
Fixed the issue
#3913