Verified status: no visual representation in Pioneer UI #4353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chrlschwb
added
jsg-code-review
community-dev
thesan
requested changes
Apr 19, 2023
| @@ -44,6 +45,7 @@ const filterReducer = (filters: MemberListFilter, action: Action): MemberListFil | |||
| return MemberListEmptyFilter | |||
|
|
|||
| case 'change': | |||
| // console.log(action.field); | |||
There was a problem hiding this comment.
Suggested change
| // console.log(action.field); |
|
@AnttoLion one more thing: the Gleev account shows when filtering verified accounts but doesn't have a tick mark. Could you check why please ? It's the only verified account I could find that isn't a FM too.
|
thesan
requested changes
Apr 24, 2023
There was a problem hiding this comment.
@AnttoLion it all looks good to me but the CI blocked the PR because apparently the code style of VerifiedMemberIcon.tsx and useMembers.ts don't fully follow the Prettier config. You can solve this by running yarn lint:fix (if it fails pull the dev branch because this script was fixed in the Ephesus release).
|
Thank you very much for all of your guidance @thesan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4300