🔧 Fix the storybook CI #4452
Merged
🔧 Fix the storybook CI #4452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parts of:
This PR fixes the new CI for PRs made from forks, which basically will be all PRs made to Pioneer very soon.
E.g this is why the CI failed on #4453.
The previous version required secrets to use the Vercel CLI, but secrets are not available on workflows triggered from a fork. So now the CI generates the Storybook deployment URL following the Vercel doc and relies on one of the few public endpoints from the Vercel REST API to wait for the deployment to complete.
I couldn't find a way to rely on the
deployment_statustrigger like in the Storybbok doc example because of the 2 other Vercel preview deployments which are almost always slower and because GH only looks at the latest run of a given job (even if the job was skipped) and ignore the previous ones.