🚚 Move the vote for proposal modal tests to Storybook #4458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thesan
force-pushed
the
feature/vote-for-proposal-modal-story
branch
from
00bf1da
to
478235d
Compare
traumschule
approved these changes
Jun 27, 2023
Comment on lines
+210
to
+211
| const container = document.getElementById('modal-container') | ||
| if (container) setContainer(container) |
There was a problem hiding this comment.
It's clear that the useEffect context defines its own container to set and overwrite the outer one to the selected element in the document tree.
|
@traumschule I can't load any domain ending in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of:
proposalstests intoPages > Proposalsstories #3559