Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐈 Make errors recoverable #4827

Merged
merged 1 commit into from
Apr 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/ui/src/app/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import '@/services/i18n'
import { ImageReportNotification } from '@/app/components/ImageReportNotification'
import { OnBoardingOverlay } from '@/app/components/OnboardingOverlay/OnBoardingOverlay'
import { CouncilModule } from '@/app/pages/Council/CouncilModule'
import { ErrorPage } from '@/app/pages/ErrorPage'
import { NotFound } from '@/app/pages/NotFound'
import { BountyRoutes } from '@/bounty/constants'
import { ConnectionStatus } from '@/common/components/ConnectionStatus'
Expand All @@ -21,7 +22,7 @@ import { ProposalsRoutes } from '@/proposals/constants/routes'
import { ValidatorsRoutes } from '@/validators/constants/routes'
import { WorkingGroupsRoutes } from '@/working-groups/constants/routes'

import { ErrorFallback } from './components/ErrorFallback'
import { ModalErrorFallback, PageErrorFallback } from './components/ErrorFallback'
import { ExtensionNotification } from './components/ExtensionWarning'
import { NavBar } from './components/NavBar'
import { SideBar } from './components/SideBar'
Expand Down Expand Up @@ -50,7 +51,7 @@ export const App = () => {
<Providers>
<Page>
<SideBar />
<ErrorBoundary FallbackComponent={ErrorFallback}>
<ErrorBoundary FallbackComponent={PageErrorFallback}>
<Screen>
<OnBoardingOverlay />
<NavBar />
Expand All @@ -70,6 +71,7 @@ export const App = () => {
<Route path={ValidatorsRoutes.list} component={ValidatorsModule} />
<Route exact path={TermsRoutes.privacyPolicy} component={PrivacyPolicy} />
<Route exact path={TermsRoutes.termsOfService} component={TermsOfService} />
<Route exact path="/error" component={ErrorPage} />
<Route exact path="/404" component={NotFound} />
<Redirect exact from="/" to={WorkingGroupsRoutes.groups} />
<Redirect exact from={ProposalsRoutes.home} to={ProposalsRoutes.current} />
Expand All @@ -78,7 +80,7 @@ export const App = () => {
</Screen>
</ErrorBoundary>
</Page>
<ErrorBoundary FallbackComponent={ErrorFallback}>
<ErrorBoundary FallbackComponent={ModalErrorFallback}>
<GlobalModals />
</ErrorBoundary>
<NotificationsHolder>
Expand Down
25 changes: 22 additions & 3 deletions packages/ui/src/app/components/ErrorFallback.tsx
Original file line number Diff line number Diff line change
@@ -1,23 +1,42 @@
import React from 'react'
import { useHistory } from 'react-router-dom'

import { ButtonPrimary, ButtonsGroup } from '@/common/components/buttons'
import { ButtonGhost, ButtonPrimary, ButtonsGroup } from '@/common/components/buttons'
import { FailureIcon } from '@/common/components/icons'
import { Modal, ModalBody, ModalFooterComponent, ModalHeader } from '@/common/components/Modal'
import { useModal } from '@/common/hooks/useModal'

interface FallbackProps {
error: Error
resetErrorBoundary: (...args: Array<unknown>) => void
}

export const ErrorFallback = ({ error, resetErrorBoundary }: FallbackProps) => {
export const PageErrorFallback = (props: FallbackProps) => {
const { push } = useHistory()
return <ErrorFallback {...props} onClose={() => push('/error')} />
}

export const ModalErrorFallback = (props: FallbackProps) => {
const { hideModal } = useModal()
return <ErrorFallback {...props} onClose={hideModal} />
}

const ErrorFallback = ({ error, resetErrorBoundary, onClose }: FallbackProps & { onClose: () => void }) => {
const handleClose = () => {
onClose()
resetErrorBoundary()
}
return (
<Modal modalSize="m" onClose={resetErrorBoundary}>
<ModalHeader icon={<FailureIcon />} title="Something went wrong" onClick={resetErrorBoundary} />
<ModalHeader icon={<FailureIcon />} title="Something went wrong" onClick={handleClose} />
<ModalBody>
<pre>{error.message}</pre>
</ModalBody>
<ModalFooterComponent>
<ButtonsGroup align="right">
<ButtonGhost size="medium" onClick={handleClose}>
Close
</ButtonGhost>
<ButtonPrimary size="medium" onClick={resetErrorBoundary}>
Try again
</ButtonPrimary>
Expand Down
7 changes: 7 additions & 0 deletions packages/ui/src/app/pages/ErrorPage.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import React from 'react'

import { PageLayout } from '@/app/components/PageLayout'

export const ErrorPage = () => {
return <PageLayout main={<h1>Something went wrong</h1>} />
}
Loading