Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sendToInflux.sh #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update sendToInflux.sh #124

wants to merge 1 commit into from

Conversation

ziehlke
Copy link

@ziehlke ziehlke commented Jun 5, 2022

don't suggest skipidentical for Influx callback as describbed in readme

@JsBergbau
Copy link
Owner

Hi ziehlke,

thanks for your contribution.
Since in sendToInflux.sh there is only an example of calling the script, I'm quite unsure if this should really be changed. Can you explain your idea behind the change more?

@ziehlke
Copy link
Author

ziehlke commented Jun 7, 2022

Hello,
sure thing! It's mere an example... but to be honest I had not read the whole readme before the first time I run the script. Ended up calling the command from the example file (RTFM !).
So I'm thinking... the example command is there... and there are seperate files for all the callbacks... I don't see the risk of handicaping other callbacks and for this particuliar case it's adviced not to include the option... so why the exmaple command wouldn't do this?
Anyways, if you think it's not worth it - no hard feelings. Great package, works like a charm. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants