fix(mask-directive): replaced native KeyboardEvent with type alias #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in order to avoid server errors we have to patch the global object with fake implementation of the KeyboardEvent and add a type alias so that the global object path is executed right before the event reference in the code fixes JsDaddy#399
|
We tried this fix in production and it works! Anyone can approve it? @NepipenkoIgor maybe? Thanks everyone! 👍 |
|
Worked at my end. Thanks guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to avoid server errors we have to patch the global object with
fake implementation of the KeyboardEvent and add a type alias so that
the global object patch is executed right before the event reference in the code
fixes #399