Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reference to bib file #44

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

xuanxu
Copy link
Contributor

@xuanxu xuanxu commented Nov 27, 2024

This PR updates the metadata of the paper source file to correctly reference the .bib file (string vs array).

Re: openjournals/joss-reviews#7313 (comment)

Copy link

github-actions bot commented Nov 27, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@xuanxu
Copy link
Contributor Author

xuanxu commented Nov 27, 2024

  • The JuBiotech maintainers know my real name.

At least one of the following two applies:

  • The JuBiotech maintainers know my current employer.

  • I am not making this contribution on behalf of my current employer.

@xuanxu
Copy link
Contributor Author

xuanxu commented Nov 27, 2024

I have read the CLA Document and I hereby sign the CLA.

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A YAML syntax problem. Of course. 🤐

Thanks a lot!

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.19%. Comparing base (b48238a) to head (5fc6476).
Report is 140 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   75.11%   75.19%   +0.08%     
==========================================
  Files           4        4              
  Lines         860      887      +27     
==========================================
+ Hits          646      667      +21     
- Misses        214      220       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelosthege michaelosthege merged commit a8376d9 into JuBiotech:main Nov 27, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
@xuanxu xuanxu deleted the patch-1 branch November 28, 2024 09:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants