Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test problem when using SkeletonView #257

Closed
bentahyar opened this issue Feb 14, 2020 · 3 comments · Fixed by #264
Closed

Unit test problem when using SkeletonView #257

bentahyar opened this issue Feb 14, 2020 · 3 comments · Fixed by #264

Comments

@bentahyar
Copy link

⚠️ Please fill out this template when filing an issue.

🙏🏼 Please check if it already exists other issue related with yours.

What did you do?

Doing a unit test

What did you expect to happen?

The value of numberOfItemsInSection returned correctly

What happened instead?

My collectionview always return the numberOfItemsInSection for skeletonview instead of the value that i return

Steps to reproduce the behavior

Do a unit test returning the value of numberOfItemsInSection while implementing SkeletonViewDataSource

SkeletonView Environment

SkeletonView version: 1.8.3
Xcode version: 11.3
Swift version: 4

@Juanpe Juanpe self-assigned this Feb 14, 2020
@Juanpe
Copy link
Owner

Juanpe commented Feb 15, 2020

Hi, let me check it

@Juanpe
Copy link
Owner

Juanpe commented Feb 20, 2020

Hi @bentahyar, the next version skips the replacement of the original data source when the tests are running.

@Czajnikowski
Copy link

Czajnikowski commented Feb 8, 2023

Now it causes a problem when snapshot testing a table view with skeleton enabled... If anybody has time it'd be good to revisit this fix and make sure that it works in both cases, or is configurable @Juanpe .

Czajnikowski added a commit to Czajnikowski/SkeletonView that referenced this issue Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants