Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It crashes the application when tap on it, didSelect called and crash #46

Closed
FarhanAnsari92 opened this issue Feb 23, 2018 · 3 comments
Closed

It crashes the application when tap on it, didSelect called and crash #46

FarhanAnsari92 opened this issue Feb 23, 2018 · 3 comments
Labels
🐞 bug ✅ fixed

Comments

@FarhanAnsari92
Copy link

FarhanAnsari92 commented Feb 23, 2018 •
edited
Loading

No description provided.

@FarhanAnsari92 FarhanAnsari92 changed the title Confusion in using It crashes the application when tap on it, didSelect called and crash Feb 23, 2018
@Visput
Copy link

Visput commented Mar 11, 2018

Same issue. User can tap on table view cell while skeleton view is shown. As result cell is highlighted and didSelect method called on UITableViewDelegate.

@Visput
Copy link

Visput commented Mar 11, 2018

Fixed by setting table view selection option dynamically:

tableView.allowsSelection = !tableView.isSkeletonActive

Juanpe added a commit that referenced this issue Mar 30, 2018
@Juanpe
fix: Issue #46
7e2849e
@Juanpe Juanpe closed this as completed May 1, 2018
@Visput
Copy link

Visput commented May 1, 2018 •
edited
Loading

Thanks for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug ✅ fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Juanpe @Visput @FarhanAnsari92