Offscreen table view layout issue fixed #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juanpe
reviewed
Feb 11, 2020
| @@ -41,6 +41,11 @@ extension SkeletonCollectionDelegate: UITableViewDelegate { | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| func tableView(_ tableView: UITableView, didEndDisplaying cell: UITableViewCell, forRowAt indexPath: IndexPath) { | |||
| cell.hideSkeleton() | |||
There was a problem hiding this comment.
Why we need to hide the skeleton? please, give me some more info :)
There was a problem hiding this comment.
If table view's frame changes after showSkeleton call, then visibleCells may return fewer cells in hideSkeleton call. Then some of cells will not receive hideSkeleton and will be reused in skeleton state.
Juanpe
changed the title
Juanpe
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AR: Some table view cells remain in skeleton state.
This happens when showAnimatedSkeleton method is called from viewDidLoad before views are laid out. Table view's storyboard frame may differ from the one it receives after layout. As well as the number of its visible cells. Therefore not all "skeletoned" cells become "unskeletoned"
This PR fixes the problem