Fix Issue #259: Prevent isSkeletonActive to be called when isSkeletonable is false #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsalim1610
changed the title
isSkeletonActive to be called when isSkeletonable is false
wsalim1610
changed the title
|
Hi @wsalim1610, please, could you include this PR in the CHANGELOG file? Copy the format of the other bug fixes :) |
|
@Juanpe done |
|
thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent
isSkeletonActiveto be called whenisSkeletonableis falseisSkeletonActivemakes a call tosubviewsSkeletonableswhich in the end will callvisibleCellsof date picker's internal table view. When this happen attraitCollectionDidChangewhich somehow happen in some iOS version where the crash happened, the crash may occurs because it is trying to access a certain index of visible cell when actually it has none yet (this happens in the date pciker internally, so I'm not really sure how or why)The changes I made is to prevent
isSkeletonActiveto be called when is it clear that the view'sisSkeletonableis false. This should prevent the crash and also I think it also better in performance as there is no point in checkingisSkeletonActivewhen it is not skeletonable