Fix to consider the top and bottom edge insets when updating the skeleton layer height #319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .top property of skeletonPaddingInsets is being used to offset the position of the skeleton layer, but the .bottom property is left unused. As a result the skeleton layer has a larger height than expected.
To reproduce de issue using the example application we can change the header label to use a bigger font:
And then add this line to configure the skeletonPaddingInsets:
The skeleton layer is larger than expected:
With the change in this PR, the .bottom property is used and the skeleton layer has the expected height:
Please tell me if I'd rather create an issue to discuss it and then add a line in the changelog if you eventually approve it.
Thanks!